Skip to content

bugfix: undo log table name dynamic derivation#7747

Merged
YvCeung merged 15 commits intoapache:2.xfrom
maple525866:bugfix/251029
Oct 31, 2025
Merged

bugfix: undo log table name dynamic derivation#7747
YvCeung merged 15 commits intoapache:2.xfrom
maple525866:bugfix/251029

Conversation

@maple525866
Copy link
Contributor

@maple525866 maple525866 commented Oct 29, 2025

Ⅰ. Describe what this PR did

PostgreSQL's rollback log table names are hardcoded, which is inconvenient for users to configure via configuration files. Configuring them can lead to failed insert operations or abnormal behavior.

This pull request retrieves the corresponding rollback log table name from the user's configuration file and updates the insert SQL statements in PostgresqlUndoLogManager. If the user hasn't configured it, the default name version is rolled back.

This issue isn't limited to PostgreSQL; it also occurs in Oracle, Oscar, and Kingbase. I've addressed this issue and added unit tests to verify its correctness.

Ⅱ. Does this pull request fix one issue?

fixes #7581

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

mvn clean test

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.21%. Comparing base (94a44ef) to head (896f019).
⚠️ Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7747      +/-   ##
============================================
+ Coverage     66.05%   66.21%   +0.15%     
  Complexity      992      992              
============================================
  Files          1323     1323              
  Lines         50152    50155       +3     
  Branches       5928     5928              
============================================
+ Hits          33130    33211      +81     
+ Misses        14110    14038      -72     
+ Partials       2912     2906       -6     
Files with missing lines Coverage Δ
...tasource/undo/kingbase/KingbaseUndoLogManager.java 71.05% <100.00%> (+60.24%) ⬆️
...m/datasource/undo/oracle/OracleUndoLogManager.java 71.05% <100.00%> (+60.24%) ⬆️
.../rm/datasource/undo/oscar/OscarUndoLogManager.java 71.05% <100.00%> (+60.24%) ⬆️
...urce/undo/postgresql/PostgresqlUndoLogManager.java 69.23% <ø> (+61.53%) ⬆️

... and 15 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@YvCeung YvCeung added the module/rm-datasource rm-datasource module label Oct 30, 2025
@YvCeung
Copy link
Contributor

YvCeung commented Oct 30, 2025

LGTM

@YvCeung YvCeung added type: bug Category issues or prs related to bug. mode: AT AT transaction mode labels Oct 30, 2025
@YvCeung YvCeung merged commit 61e375f into apache:2.x Oct 31, 2025
11 checks passed
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mode: AT AT transaction mode module/rm-datasource rm-datasource module type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sequence name undo_log_id_seq in PostgresqlUndoLogManager breaks custom undo_log table configuration

2 participants