Skip to content

Conversation

@slievrly
Copy link
Member

Ⅰ. Describe what this PR did

fix some spell errors in code and comments

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Oct 19, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.27%. Comparing base (f9345e0) to head (3d6bfe0).
⚠️ Report is 4 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ain/java/org/apache/seata/server/ServerRunner.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7710      +/-   ##
============================================
- Coverage     67.29%   67.27%   -0.02%     
  Complexity      992      992              
============================================
  Files          1323     1323              
  Lines         50155    50155              
  Branches       5928     5928              
============================================
- Hits          33750    33744       -6     
+ Misses        13485    13482       -3     
- Partials       2920     2929       +9     
Files with missing lines Coverage Δ
...che/seata/common/util/NetAddressValidatorUtil.java 76.92% <ø> (ø)
...ta/spring/boot/autoconfigure/StarterConstants.java 100.00% <ø> (ø)
.../src/main/java/org/apache/seata/server/Server.java 74.28% <100.00%> (ø)
...ain/java/org/apache/seata/server/ServerRunner.java 65.62% <0.00%> (ø)

... and 13 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting PR.
While checking the changes, I found some typos that I had previously thought were correct :)

Copy link
Contributor

@YoWuwuuuw YoWuwuuuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Changes have not yet been registered.

@slievrly slievrly merged commit dbcd5af into apache:2.x Nov 4, 2025
10 of 11 checks passed
@slievrly slievrly added this to the 2.6.0 milestone Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants