Skip to content

bugfix: fix DM transaction rollback not using database auto-increment primary keys#7643

Merged
slievrly merged 8 commits intoapache:2.xfrom
chenmuhu:2.x
Oct 17, 2025
Merged

bugfix: fix DM transaction rollback not using database auto-increment primary keys#7643
slievrly merged 8 commits intoapache:2.xfrom
chenmuhu:2.x

Conversation

@chenmuhu
Copy link
Contributor

@chenmuhu chenmuhu commented Sep 17, 2025

Check if an auto-increment primary key is used; if so, use it, otherwise do not use it.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #7642

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

修改成:检测试有没有用到自增主键,有则使用自增主键,否则不使用
@YvCeung
Copy link
Contributor

YvCeung commented Sep 17, 2025

  1. Could you convert the title of pr to English
  2. Please ensure that the changed code can be covered by the unit test cases
  3. You can supplement your github information in these two files
    changes/en-us/2.x.md
    changes/zh-cn/2.x.md

@xingfudeshi xingfudeshi changed the title 解决:dm事务回滚的时候,用的不是数据库自增主键 #7642 bugfix:Fix DM transaction rollback not using database auto-increment primary keys Sep 18, 2025
@xingfudeshi
Copy link
Member

​​The CI tests are failing, so please fix them. Also, please add an entry for your PR to the change log.​​

@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.41%. Comparing base (b912ab7) to head (bf9876c).
⚠️ Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ta/rm/datasource/undo/dm/DmUndoDeleteExecutor.java 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7643      +/-   ##
============================================
- Coverage     61.51%   61.41%   -0.10%     
- Complexity      680      682       +2     
============================================
  Files          1323     1323              
  Lines         49930    49943      +13     
  Branches       5881     5885       +4     
============================================
- Hits          30714    30674      -40     
- Misses        16429    16505      +76     
+ Partials       2787     2764      -23     
Files with missing lines Coverage Δ
...ta/rm/datasource/undo/dm/DmUndoDeleteExecutor.java 0.00% <0.00%> (ø)

... and 42 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slievrly slievrly changed the title bugfix:Fix DM transaction rollback not using database auto-increment primary keys bugfix: fix DM transaction rollback not using database auto-increment primary keys Sep 29, 2025
@slievrly slievrly added this to the 2.6.0 milestone Sep 29, 2025
@maple525866
Copy link
Contributor

maple525866 commented Sep 29, 2025

https://github.com/apache/incubator-seata/actions/runs/18087650202/job/51461393434?pr=7643
Please use mvn spotless:apply to fix the formatting issues

@YvCeung
Copy link
Contributor

YvCeung commented Oct 16, 2025

@chenmuhu any response here?

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is merged first, and the code style will be handled in the subsequent PR.

@slievrly slievrly merged commit d239a81 into apache:2.x Oct 17, 2025
8 of 9 checks passed
@funky-eyes funky-eyes added mode: AT AT transaction mode module/rm-datasource rm-datasource module multilingual labels Oct 17, 2025
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mode: AT AT transaction mode module/rm-datasource rm-datasource module multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dm8事务回滚的时候,用的不是数据库自增主键

6 participants