Skip to content

Conversation

@xjlgod
Copy link
Contributor

@xjlgod xjlgod commented Jul 17, 2025

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

this class should not be relied by client side, it will cause spring version compatible problem. I found this error by springboot-sofarpc-seata-tcc sample.
this pr should be merged in 2.5.0.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.53%. Comparing base (88bba2f) to head (fc4a2cc).
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #7546      +/-   ##
============================================
+ Coverage     60.49%   60.53%   +0.04%     
- Complexity      656      658       +2     
============================================
  Files          1298     1298              
  Lines         49081    49081              
  Branches       5771     5771              
============================================
+ Hits          29691    29713      +22     
+ Misses        16757    16737      -20     
+ Partials       2633     2631       -2     
Files with missing lines Coverage Δ
...onfigure/http/RestControllerBeanPostProcessor.java 93.75% <ø> (ø)

... and 7 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xjlgod xjlgod changed the title fix: fix client spring version compatible bugfix: fix client spring version compatible Jul 18, 2025
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes modified the milestones: 2.6.0, 2.5.0 Jul 18, 2025
@xjlgod xjlgod merged commit 608785f into apache:2.x Jul 18, 2025
10 checks passed
xjlgod added a commit to xjlgod/seata that referenced this pull request Jul 18, 2025
* fix: fix client spring version compatible

* fix: fix client spring version compatible

* fix: fix client spring version compatible

* bugfix: fix client spring version compatible

* bugfix: fix client spring version compatible
xjlgod added a commit that referenced this pull request Jul 19, 2025
* fix: fix client spring version compatible

* fix: fix client spring version compatible

* fix: fix client spring version compatible

* bugfix: fix client spring version compatible

* bugfix: fix client spring version compatible
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
* fix: fix client spring version compatible

* fix: fix client spring version compatible

* fix: fix client spring version compatible

* bugfix: fix client spring version compatible

* bugfix: fix client spring version compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants