optimize: seata-server independent HTTP thread pool #7415

YoWuwuuuw · 2025-06-05T11:15:15Z

I have registered the PR changes.

Ⅰ. Describe what this PR did

Currently, seata-server uses netty to manage network requests, and HTTP request processing is executed synchronously with the io thread pool of netty itself. At the same time, due to the mechanism of multiple protocols on a single port, blocking may occur under high concurrency.
Therefore, an independent thread pool is added to process HTTP requests for processing of HTTP requests asynchronously. (align seata, grpc protocol asynchronous processing)

Ⅱ. Does this pull request fix one issue?

#7405

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

YongGoose · 2025-06-05T11:57:34Z

@YoWuwuuuw

I think we need to address the issue below.

Error:  Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.8:check (pmd-check) on project seata-core: You have 1 PMD violation. For more details see: /home/runner/work/incubator-seata/incubator-seata/core/target/pmd.xml -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.8:check (pmd-check) on project seata-core: You have 1 PMD violation. For more details see: /home/runner/work/incubator-seata/incubator-seata/core/target/pmd.xml
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)

core/src/main/java/org/apache/seata/core/rpc/netty/http/HttpDispatchHandler.java

YoWuwuuuw · 2025-06-05T14:53:44Z

@YoWuwuuuw

I think we need to address the issue below.

Error:  Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.8:check (pmd-check) on project seata-core: You have 1 PMD violation. For more details see: /home/runner/work/incubator-seata/incubator-seata/core/target/pmd.xml -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-pmd-plugin:3.8:check (pmd-check) on project seata-core: You have 1 PMD violation. For more details see: /home/runner/work/incubator-seata/incubator-seata/core/target/pmd.xml
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:215)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:156)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:148)

Strangely, I did not fail the pmd-check locally

funky-eyes · 2025-06-05T15:21:08Z

This branch has conflicts that must be resolved
Use the web editor or the command line to resolve conflicts before continuing.

core/src/main/java/org/apache/seata/core/rpc/netty/http/HttpDispatchHandler.java

# Conflicts: # core/src/main/java/org/apache/seata/core/rpc/netty/http/HttpDispatchHandler.java

funky-eyes

Error: ClusterControllerTest.watch:97 expected: <200> but was: <500>
Error: ClusterControllerTest.watchTimeoutTest:66 expected: <304> but was: <500>

funky-eyes · 2025-06-06T08:10:35Z

core/src/main/java/org/apache/seata/core/rpc/netty/http/HttpDispatchHandler.java

+        Object[] args = ParameterParser.getArgValues(httpInvocation.getParamMetaData(), handleMethod,
                requestDataNode, httpContext);
-            Object result = handleMethod.invoke(httpController, args);
+        Object result = handleMethod.invoke(httpController, args);


I believe the code range that should be asynchronous is only between lines 132-138.

codecov · 2025-06-07T08:33:05Z

Codecov Report

Attention: Patch coverage is 78.46154% with 14 lines in your changes missing coverage. Please review.

Project coverage is 59.09%. Comparing base (e4a87e6) to head (4e97d47).
Report is 1 commits behind head on 2.x.

Files with missing lines	Patch %	Lines
...seata/core/rpc/netty/http/HttpDispatchHandler.java	65.85%	12 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #7415      +/-   ##
============================================
- Coverage     59.11%   59.09%   -0.03%     
  Complexity      529      529              
============================================
  Files          1281     1281              
  Lines         46102    46142      +40     
  Branches       5562     5561       -1     
============================================
+ Hits          27255    27267      +12     
- Misses        16274    16312      +38     
+ Partials       2573     2563      -10

Files with missing lines	Coverage Δ
...ava/org/apache/seata/common/ConfigurationKeys.java	`0.00% <ø> (ø)`
...in/java/org/apache/seata/common/DefaultValues.java	`100.00% <ø> (ø)`
...apache/seata/core/rpc/netty/NettyServerConfig.java	`70.88% <100.00%> (+3.28%)`	⬆️
.../autoconfigure/properties/TransportProperties.java	`95.89% <100.00%> (+1.15%)`	⬆️
...seata/core/rpc/netty/http/HttpDispatchHandler.java	`70.12% <65.85%> (+4.55%)`	⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

core/src/main/java/org/apache/seata/core/rpc/netty/http/HttpDispatchHandler.java

…spatchHandler.java

funky-eyes

LGTM

funky-eyes · 2025-06-08T07:08:54Z

core/src/main/java/org/apache/seata/core/rpc/netty/NettyServerConfig.java

    private static boolean ENABLE_TC_SERVER_BATCH_SEND_RESPONSE = CONFIG.getBoolean(ConfigurationKeys.ENABLE_TC_SERVER_BATCH_SEND_RESPONSE,
        DefaultValues.DEFAULT_ENABLE_TC_SERVER_BATCH_SEND_RESPONSE);

+    private static int minHttpPoolSize = CONFIG.getInt(ConfigurationKeys.MIN_HTTP_POOL_SIZE, 10);


https://github.com/apache/incubator-seata/tree/2.x/seata-spring-autoconfigure/seata-spring-autoconfigure-server/src/main/java/org/apache/seata/spring/boot/autoconfigure/properties/server
Need to supplement the properties class for obtaining configurations, and also add configuration items to these three configuration file
https://github.com/apache/incubator-seata/blob/2.x/server/src/main/resources/application.example.yml
https://github.com/apache/incubator-seata/blob/2.x/server/src/main/resources/application.raft.example.yml
https://github.com/apache/incubator-seata/blob/2.x/script/config-center/config.txt

@funky-eyes I have a little bit of a question

Currently, the thread pool for handling Seata and gRPC protocols uses System.getProperty for configuration:

private static int minServerPoolSize = Integer.parseInt(System.getProperty(ConfigurationKeys.MIN_SERVER_POOL_SIZE, "50")); private static int maxServerPoolSize = Integer.parseInt(System.getProperty(ConfigurationKeys.MAX_SERVER_POOL_SIZE, "500")); private static int maxTaskQueueSize = Integer.parseInt(System.getProperty(ConfigurationKeys.MAX_TASK_QUEUE_SIZE, "20000")); private static int keepAliveTime = Integer.parseInt(System.getProperty(ConfigurationKeys.KEEP_ALIVE_TIME, "500"));

In older versions, System.getProperty was used for configurations, which seemingly limited modifications to only through JVM startup parameters in the command script.

Conversely, the HTTP thread pool is configured using CONFIG.getInt:

private static int minHttpPoolSize = CONFIG.getInt(ConfigurationKeys.MIN_HTTP_POOL_SIZE, 10); private static int maxHttpPoolSize = CONFIG.getInt(ConfigurationKeys.MAX_HTTP_POOL_SIZE, 100); private static int maxHttpTaskQueueSize = CONFIG.getInt(ConfigurationKeys.MAX_HTTP_TASK_QUEUE_SIZE, 1000); private static int httpKeepAliveTime = CONFIG.getInt(ConfigurationKeys.HTTP_POOL_KEEP_ALIVE_TIME, 500);

CONFIG.getInt supports various configuration sources, including system properties, environment variables, configuration files (e.g., Spring Boot's application.yaml), and configuration centers.
To fully leverage this, these configurations should be integrated into the seata.spring.boot.autoconfigure module(for configuration files) and added to seata/blob/2.x/script/config-center/config.txt(for config-center).

Therefore, I believe if the HTTP message handling thread pool configuration uses CONFIG.getInt, then the thread pools for Seata and gRPC messages should also switch to this configuration method. This would enable support for Spring Boot's application.yaml and integrated configuration center modes.

Additionally, I think all System.getProperty usages should be updated to CONFIG.getInt, as CONFIG.getInt encompasses all functionalities of System.getProperty.

Can you answer my confusion, thank you.

I agree with your point. You can submit a new PR to make the thread pool configurations for Seata and gRPC read from CONFIG as well.

YoWuwuuuw added 3 commits June 5, 2025 17:35

optimize: support independent HTTP thread pool

ecb00fa

test: fix mock

25e8917

add changes

abf53aa

YongGoose linked an issue Jun 5, 2025 that may be closed by this pull request

Seata-Server: independent HTTP thread pool #7405

Closed

funky-eyes reviewed Jun 5, 2025

View reviewed changes

core/src/main/java/org/apache/seata/core/rpc/netty/http/HttpDispatchHandler.java Outdated Show resolved Hide resolved

optimize: change to abortPolicy and return 503

3367168

YoWuwuuuw added 2 commits June 6, 2025 11:37

Merge branch '2.x' into 20250605

d786cdd

# Conflicts: # core/src/main/java/org/apache/seata/core/rpc/netty/http/HttpDispatchHandler.java

resolve conflicts

4a78045

funky-eyes reviewed Jun 6, 2025

View reviewed changes

funky-eyes added this to the 2.5.0 milestone Jun 6, 2025

funky-eyes added module/core core module type: optimize labels Jun 6, 2025

funky-eyes reviewed Jun 6, 2025

View reviewed changes

optimize: Change asynchronous process range

614ffaf

YoWuwuuuw force-pushed the 20250605 branch from 464a3e1 to 614ffaf Compare June 6, 2025 09:11

YoWuwuuuw added 6 commits June 6, 2025 17:12

Merge branch '2.x' into 20250605

e995cf4

remove useless import

680fbee

Merge remote-tracking branch 'origin/20250605' into 20250605

fc8c19b

Merge branch '2.x' into 20250605

cda7b63

pmd check

e43b755

Merge remote-tracking branch 'origin/20250605' into 20250605

2c19474

funky-eyes reviewed Jun 8, 2025

View reviewed changes

core/src/main/java/org/apache/seata/core/rpc/netty/http/HttpDispatchHandler.java Outdated Show resolved Hide resolved

Update core/src/main/java/org/apache/seata/core/rpc/netty/http/HttpDi…

2438e31

…spatchHandler.java

funky-eyes approved these changes Jun 8, 2025

View reviewed changes

funky-eyes reviewed Jun 8, 2025

View reviewed changes

optimize: add config-center and springboot configuration mode config

a62db1c

Merge remote-tracking branch 'origin/20250605' into 20250605

4e97d47

YoWuwuuuw mentioned this pull request Jun 8, 2025

Refactor: seata-core configuration management mode YoWuwuuuw/incubator-seata#22

Open

funky-eyes merged commit 1b2f845 into apache:2.x Jun 8, 2025
9 checks passed

YoWuwuuuw mentioned this pull request Jun 21, 2025

Refactor: server netty config changed to use CONFIG format #7461

Merged

1 task

slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025

optimize: seata-server independent HTTP thread pool (apache#7415)

2f5b0a5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

optimize: seata-server independent HTTP thread pool #7415

optimize: seata-server independent HTTP thread pool #7415

Uh oh!

YoWuwuuuw commented Jun 5, 2025 •

edited

Loading

Uh oh!

YongGoose commented Jun 5, 2025

Uh oh!

Uh oh!

YoWuwuuuw commented Jun 5, 2025

Uh oh!

funky-eyes commented Jun 5, 2025

Uh oh!

funky-eyes left a comment

Uh oh!

funky-eyes Jun 6, 2025

Uh oh!

codecov bot commented Jun 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

funky-eyes left a comment

Uh oh!

funky-eyes Jun 8, 2025

Uh oh!

YoWuwuuuw Jun 8, 2025

Uh oh!

funky-eyes Jun 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

optimize: seata-server independent HTTP thread pool #7415

optimize: seata-server independent HTTP thread pool #7415

Uh oh!

Conversation

YoWuwuuuw commented Jun 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

YongGoose commented Jun 5, 2025

Uh oh!

Uh oh!

YoWuwuuuw commented Jun 5, 2025

Uh oh!

funky-eyes commented Jun 5, 2025

Uh oh!

funky-eyes left a comment

Choose a reason for hiding this comment

Uh oh!

funky-eyes Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

funky-eyes left a comment

Choose a reason for hiding this comment

Uh oh!

funky-eyes Jun 8, 2025

Choose a reason for hiding this comment

Uh oh!

YoWuwuuuw Jun 8, 2025

Choose a reason for hiding this comment

Uh oh!

funky-eyes Jun 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YoWuwuuuw commented Jun 5, 2025 •

edited

Loading

codecov bot commented Jun 7, 2025 •

edited

Loading