Skip to content

bugfix: Fix missing branchType in BusinessActionContext#7188

Merged
funky-eyes merged 11 commits intoapache:2.xfrom
YongGoose:feature/7186
Mar 3, 2025
Merged

bugfix: Fix missing branchType in BusinessActionContext#7188
funky-eyes merged 11 commits intoapache:2.xfrom
YongGoose:feature/7186

Conversation

@YongGoose
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #7186

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@YongGoose YongGoose changed the title fix: Fix missing branchType in BusinessActionContext bugfix: Fix missing branchType in BusinessActionContext Feb 28, 2025
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.4.0 milestone Feb 28, 2025
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. mode: TCC TCC transaction mode module/tcc tcc module labels Feb 28, 2025
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.54%. Comparing base (cde5a7d) to head (300b766).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                2.x    #7188   +/-   ##
=========================================
  Coverage     51.54%   51.54%           
  Complexity     6806     6806           
=========================================
  Files          1169     1169           
  Lines         41461    41463    +2     
  Branches       4850     4850           
=========================================
+ Hits          21372    21374    +2     
+ Misses        18072    18070    -2     
- Partials       2017     2019    +2     
Files with missing lines Coverage Δ
...va/org/apache/seata/rm/tcc/TCCResourceManager.java 58.69% <100.00%> (+0.60%) ⬆️

... and 2 files with indirect coverage changes

@funky-eyes funky-eyes merged commit ba1f753 into apache:2.x Mar 3, 2025
8 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mode: TCC TCC transaction mode module/tcc tcc module type: bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seata TCC模式下commit方法和rollback方法branchType缺失

3 participants