Skip to content

optimize: remove org.eclipse.jetty dependency#7138

Merged
funky-eyes merged 4 commits intoapache:2.xfrom
YongGoose:feature/7137
Feb 8, 2025
Merged

optimize: remove org.eclipse.jetty dependency#7138
funky-eyes merged 4 commits intoapache:2.xfrom
YongGoose:feature/7137

Conversation

@YongGoose
Copy link
Member

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #7137

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.78%. Comparing base (bf3fe24) to head (be3ca60).
Report is 1 commits behind head on 2.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #7138      +/-   ##
============================================
- Coverage     51.78%   51.78%   -0.01%     
- Complexity     6753     6756       +3     
============================================
  Files          1151     1151              
  Lines         40970    40970              
  Branches       4803     4803              
============================================
- Hits          21217    21215       -2     
- Misses        17758    17762       +4     
+ Partials       1995     1993       -2     

see 4 files with indirect coverage changes

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to know where jetty is used, and whether we can remove it directly?

@slievrly
Copy link
Member

slievrly commented Feb 7, 2025

I want to know where jetty is used, and whether we can remove it directly?

The org.eclipse.jetty:* dependency is only referenced in the seata-discovery-zk module, so it looks like it can be removed. It was probably needed back when org.apache.zookeeper:* hadn't been replaced with org.apache.curator:* yet.

@YongGoose YongGoose changed the title optimize: upgrade jetty to 9.4.57.v20241219 optimize: remove org.eclipse.jetty dependency Feb 8, 2025
@YongGoose
Copy link
Member Author

I want to know where jetty is used, and whether we can remove it directly?

The org.eclipse.jetty:* dependency is only referenced in the seata-discovery-zk module, so it looks like it can be removed. It was probably needed back when org.apache.zookeeper:* hadn't been replaced with org.apache.curator:* yet.

Done in de5ba5b !

PTAL :)

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 2.4.0 milestone Feb 8, 2025
@funky-eyes funky-eyes added dependencies Pull requests that update a dependency file type: optimize labels Feb 8, 2025
@YongGoose YongGoose requested a review from funky-eyes February 8, 2025 01:39
@funky-eyes funky-eyes merged commit 903c6a3 into apache:2.x Feb 8, 2025
8 checks passed
slievrly pushed a commit to slievrly/fescar that referenced this pull request Oct 21, 2025
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file type: optimize

Development

Successfully merging this pull request may close these issues.

jetty 9.4.38 has 5 CVE security issues associated with it

3 participants