optimize: remove org.eclipse.jetty dependency#7138
Conversation
0390199 to
b7e70db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7138 +/- ##
============================================
- Coverage 51.78% 51.78% -0.01%
- Complexity 6753 6756 +3
============================================
Files 1151 1151
Lines 40970 40970
Branches 4803 4803
============================================
- Hits 21217 21215 -2
- Misses 17758 17762 +4
+ Partials 1995 1993 -2 |
funky-eyes
left a comment
There was a problem hiding this comment.
I want to know where jetty is used, and whether we can remove it directly?
The org.eclipse.jetty:* dependency is only referenced in the seata-discovery-zk module, so it looks like it can be removed. It was probably needed back when org.apache.zookeeper:* hadn't been replaced with org.apache.curator:* yet. |
Done in de5ba5b ! PTAL :) |
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #7137
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews