bugfix: the issue of incorrect annotation retrieval from the proxy object#7107
bugfix: the issue of incorrect annotation retrieval from the proxy object#7107funky-eyes merged 6 commits intoapache:2.xfrom
Conversation
spring/src/test/java/org/apache/seata/spring/tcc/EasyTccAction.java
Outdated
Show resolved
Hide resolved
spring/src/test/java/org/apache/seata/spring/tcc/EasyTccActionImpl.java
Outdated
Show resolved
Hide resolved
spring/src/test/java/org/apache/seata/spring/tcc/EasyTccActionImpl.java
Outdated
Show resolved
Hide resolved
spring/src/test/java/org/apache/seata/spring/tcc/EasyTccAction.java
Outdated
Show resolved
Hide resolved
|
@xingfudeshi 老哥 这里再帮忙看看 我还需要做些什么吗 多谢🌹 |
|
xingfudeshi
left a comment
There was a problem hiding this comment.
The unit test does not pass, please fix it. Also, please add this PR to the change log.
|
@xingfudeshi 老哥 这里我处理好了 帮忙再看看 另外我有个问题想请教一下 这里跑的workflow是等价于mvn clean test吗?我在本地跑的test没法复现这里的问题,反而有其他失败的单测用例,请问有遇到过类似问题吗? |
Yes.The workflow will run the following command: For details, Please refer to https://github.com/apache/incubator-seata/blob/2.x/.github/workflows/build.yml |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7107 +/- ##
============================================
+ Coverage 53.08% 53.17% +0.09%
- Complexity 6795 6809 +14
============================================
Files 1136 1137 +1
Lines 40341 40365 +24
Branches 4723 4727 +4
============================================
+ Hits 21416 21466 +50
+ Misses 16885 16854 -31
- Partials 2040 2045 +5
|
多谢老哥,这里还有我需要修改的地方吗,我看单测都通过,覆盖率的部分需要修改吗? |
|
@xingfudeshi 老哥 这里辛苦再帮忙看看🌹 |
|
请将你的钉钉号发到我的邮件中,我将邀请你加入seata贡献者群中 |

Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
fixes #7047
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews