bugfix: fix cache scheduled refresh issue.#6661
Conversation
funky-eyes
left a comment
There was a problem hiding this comment.
我认为应该将take改为poll,加上超时时间就可以了,不需要独立一个线程去处理这个刷新缓存时间,你觉得呢?
I think we should change "take" to "poll" and add a timeout, that should be enough. We don't need a separate thread to handle the cache refresh time. What do you think about that?
OK, Good idea |
|
@funky-eyes It has been modified, and at the same time, I have changed the |
funky-eyes
left a comment
There was a problem hiding this comment.
LGTM
麻烦在changelog中找到中英两版语言的2.x.md在其中将该pr登记,并登记你的github信息
|
请把你的钉钉联系方式发送至:[email protected] 我将邀请你加入seata开发者群中 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6661 +/- ##
============================================
- Coverage 51.13% 50.77% -0.36%
- Complexity 5317 5642 +325
============================================
Files 950 1023 +73
Lines 33448 35440 +1992
Branches 4048 4216 +168
============================================
+ Hits 17103 17995 +892
- Misses 14666 15644 +978
- Partials 1679 1801 +122
|
Ⅰ. Describe what this PR did
Restore some code and fix cache scheduled refresh issue.
Ⅱ. Does this pull request fix one issue?
fixes #6660
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews