optimize: optimization fails to build frontend on arm64 #6265
Merged
xingfudeshi merged 5 commits intoapache:2.xfrom Jan 18, 2024
Merged
optimize: optimization fails to build frontend on arm64 #6265xingfudeshi merged 5 commits intoapache:2.xfrom
xingfudeshi merged 5 commits intoapache:2.xfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6265 +/- ##
============================================
- Coverage 51.07% 51.04% -0.04%
+ Complexity 5097 5092 -5
============================================
Files 918 918
Lines 32031 32031
Branches 3865 3865
============================================
- Hits 16361 16350 -11
- Misses 14097 14104 +7
- Partials 1573 1577 +4 |
slievrly
reviewed
Jan 17, 2024
Member
slievrly
left a comment
There was a problem hiding this comment.
This is an optimization PR; only functional bugs are considered bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews