optimize: validate that the primary key is free of illegal characters#6227
Merged
xingfudeshi merged 4 commits intoapache:2.xfrom Jan 2, 2024
Merged
optimize: validate that the primary key is free of illegal characters#6227xingfudeshi merged 4 commits intoapache:2.xfrom
xingfudeshi merged 4 commits intoapache:2.xfrom
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6227 +/- ##
============================================
- Coverage 48.98% 48.95% -0.03%
- Complexity 4779 4780 +1
============================================
Files 915 915
Lines 31896 31901 +5
Branches 3855 3855
============================================
- Hits 15624 15618 -6
- Misses 14710 14722 +12
+ Partials 1562 1561 -1
|
funky-eyes
reviewed
Jan 2, 2024
Contributor
funky-eyes
left a comment
funky-eyes
left a comment
There was a problem hiding this comment.
Please add changelog.
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
validate that the primary key is free of ","
fixes: #5136
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews