bugfix: The TCC aspect does not handle internal invocation exceptions and directly throws them externally.#6090
Merged
funky-eyes merged 6 commits intoapache:2.xfrom Dec 1, 2023
Conversation
leezongjie
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.x #6090 +/- ##
============================================
+ Coverage 49.23% 49.27% +0.03%
- Complexity 4790 4799 +9
============================================
Files 913 913
Lines 31677 31685 +8
Branches 3824 3825 +1
============================================
+ Hits 15597 15613 +16
+ Misses 14535 14523 -12
- Partials 1545 1549 +4
|
funky-eyes
changed the title
funky-eyes
added
type: bug
funky-eyes
reviewed
Nov 28, 2023
Contributor
funky-eyes
left a comment
funky-eyes
left a comment
There was a problem hiding this comment.
建议补充一个测试用例，证明其不再是runtimeexception
It is recommended to add a test case to prove that it is no longer a RuntimeException
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
# Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md
l81893521
pushed a commit
to l81893521/seata
that referenced
this pull request
Dec 2, 2023
… and directly throws them externally. (apache#6090)
YvCeung
pushed a commit
to YvCeung/incubator-seata
that referenced
this pull request
Dec 25, 2025
… and directly throws them externally. (apache#6090)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.x版本中支持去spring能力，对切面部分做了重构处理，如果tcc一二阶段rpc调用过程出现异常，会多加一层框架内部异常，部分业务之前会严格校验rpc调用产生的原生异常，这样会导致原判断失效不成立。为了兼容做处理，直接将异常抛出。
fixes #6084