Skip to content

optimize: possible conflict between asyncCommitting thread and retryCommitting thread#5623

Merged
funky-eyes merged 2 commits intoapache:2.xfrom
sixlei:2.x
Jun 1, 2023
Merged

optimize: possible conflict between asyncCommitting thread and retryCommitting thread#5623
funky-eyes merged 2 commits intoapache:2.xfrom
sixlei:2.x

Conversation

@sixlei
Copy link
Contributor

@sixlei sixlei commented May 30, 2023

…Committing thread

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

fix possible conflict between asyncCommitting thread and retryCommitting thread
重试线程需要对Commited状态的全局事务做重试提交时,应该先判断该全局事务是否是DeadSession。只有DeadSession状态的才能重试提交。避免和异步提交线程的删除全局事务逻辑发生并发冲突

Ⅱ. Does this pull request fix one issue?

fixes #5605

Ⅲ. Why don't you add test cases (unit test/integration test)?

Original test cases can be do

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM changes 文件夹里的2.0.0.md中英文两版都把pr和作者信息登记一下

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM changes 文件夹里的2.0.0.md中英文两版都把pr和作者信息登记一下

@funky-eyes funky-eyes added this to the 2.0.0 milestone May 31, 2023
@funky-eyes
Copy link
Contributor

这个不算bug,应该定义为一个optimize

@sixlei
Copy link
Contributor Author

sixlei commented May 31, 2023

这个不算bug,应该定义为一个optimize

这里需要重新提pr嘛,还是我重新提交下就行

@funky-eyes
Copy link
Contributor

这个不算bug,应该定义为一个optimize

这里需要重新提pr嘛,还是我重新提交下就行

改下标题,然后签署cla,登记changelog直接在你这个pr的分支上提交代码就行了

@funky-eyes funky-eyes added the first-time contributor first-time contributor label May 31, 2023
@sixlei sixlei changed the title bugfix:fix possible conflict between asyncCommitting thread and retryCommitting thread optimize:optimize possible conflict between asyncCommitting thread and retryCommitting thread May 31, 2023
@sixlei sixlei closed this May 31, 2023
sixlei pushed a commit to sixlei/seata that referenced this pull request May 31, 2023
@sixlei sixlei reopened this May 31, 2023
@CLAassistant
Copy link

CLAassistant commented May 31, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes changed the title optimize:optimize possible conflict between asyncCommitting thread and retryCommitting thread optimize: possible conflict between asyncCommitting thread and retryCommitting thread Jun 1, 2023
@funky-eyes funky-eyes merged commit 3213ca3 into apache:2.x Jun 1, 2023
Pil0tXia pushed a commit to Pil0tXia/seata that referenced this pull request Jun 14, 2023
my change 2

optimize: optimize channel availability thread log output (apache#5563)

feature:docker image supports JVM parameter injection (apache#5529)

test: add unit test for transaction messages (apache#5637)

feature: support trace the transaction link according to the XID (apache#5600)

test: add unit test case for ExporterType/RegistryType (apache#5622)

optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623)

optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623)

optimize: support case-sensitive attributes for table and column metadata (apache#5553)
Pil0tXia pushed a commit to Pil0tXia/seata that referenced this pull request Jun 14, 2023
my change 2

optimize: optimize channel availability thread log output (apache#5563)

feature:docker image supports JVM parameter injection (apache#5529)

test: add unit test for transaction messages (apache#5637)

feature: support trace the transaction link according to the XID (apache#5600)

test: add unit test case for ExporterType/RegistryType (apache#5622)

optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623)

optimize: possible conflict between asyncCommitting thread and retryCommitting thread (apache#5623)

optimize: support case-sensitive attributes for table and column metadata (apache#5553) (+14 squashed commit)

Squashed commit:

[c97f409] mychange 1

my change 2

optimize: optimize channel availability thread log output (apache#5563)

feature:docker image supports JVM parameter injection (apache#5529)

test: add unit test for transaction messages (apache#5637)

feature: support trace the transaction link according to the XID (apache#5600)

test: add unit test case for ExporterType/RegistryType (apache#5622)

[8f9bba2] bugfix: fix the `asyncCommit` and `queueToRetryCommit` always failed in db mode (apache#5604)

[b2d4584] bugfix: fix log in participant transaction role (apache#5594)

[d0d012c] feature: support sqlserver in AT mode (apache#3887)

[54bd3ca] feature:support MS SqlServer on the server side of AT mode (apache#4033)

[d1e6e6b] bugfix: grpc interceptor xid unbinding problem (apache#5577)

[0b49e06] optimize: The common fence clean task is only initiated when useTCCFence is set to true (apache#5576)

[7e40e05] bugfix: fix mariadb rollback failed (apache#5558)

[ee1ecf7] bugfix: fix oracle insert undolog failed (apache#5556)

Signed-off-by: slievrly <slievrly@163.com>

[0a1edf3] optimize: update expire gpg key and publish workflow (apache#5549)

Signed-off-by: slievrly <slievrly@163.com>

[1c8e4bf] bugfix: the log file path was loaded incorrectly (apache#5531)

[c73d72d] bugfix: fix GlobalStatus=9 can't be cleared in DB storage mode (apache#5523)

[83493d9] optimize: optimize FenceHandler for oracle (apache#5519)

[9b35ba9] bugfix: fix the full table scan issue with 'setDate' condition in Oracle 10g (apache#5498)
YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible conflict between asyncCommitting thread and retryCommitting thread

4 participants