optimize: rm appdata size limit by Bughue · Pull Request #4473 · apache/incubator-seata

Bughue · 2022-03-15T09:33:33Z

Ⅰ. Describe what this PR did

新增判断：一阶段上传的appdata数据大小。TC和RM都有判断。除了抛出错误的判断值也加入了warningsize的值，作为用户数据越来越大时的一个提醒。

Ⅱ. Does this pull request fix one issue?

fixes #4421

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

server/src/main/java/io/seata/server/coordinator/AbstractCore.java

common/src/main/java/io/seata/common/DefaultValues.java

rm/src/main/java/io/seata/rm/AbstractResourceManager.java

codecov-commenter · 2022-08-25T03:10:54Z

Codecov Report

Merging #4473 (df1c0ad) into 2.x (2122c6d) will increase coverage by 0.02%.
The diff coverage is 42.55%.

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x    #4473      +/-   ##
============================================
+ Coverage     49.54%   49.57%   +0.02%     
- Complexity     4766     4786      +20     
============================================
  Files           909      909              
  Lines         31390    31418      +28     
  Branches       3782     3778       -4     
============================================
+ Hits          15553    15575      +22     
- Misses        14300    14312      +12     
+ Partials       1537     1531       -6

Files	Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java	`0.00% <ø> (ø)`
...n/src/main/java/io/seata/common/DefaultValues.java	`0.00% <ø> (ø)`
...java/io/seata/server/coordinator/AbstractCore.java	`54.73% <66.66%> (+0.71%)`	⬆️
.../autoconfigure/properties/client/RmProperties.java	`37.70% <25.00%> (-1.92%)`	⬇️
...oconfigure/properties/server/ServerProperties.java	`27.27% <25.00%> (-0.51%)`	⬇️
...rc/main/java/io/seata/common/util/StringUtils.java	`44.48% <45.45%> (+3.41%)`	⬆️

... and 8 files with indirect coverage changes

CLAassistant · 2022-12-12T13:17:21Z

All committers have signed the CLA.

CLAassistant · 2022-12-12T13:17:30Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 5 committers have signed the CLA.

❌ liuqiufeng
❌ Bughue
❌ pengten
❌ slievrly
❌ caohdgege
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

rm/src/main/java/io/seata/rm/AbstractResourceManager.java

server/src/main/java/io/seata/server/coordinator/AbstractCore.java

# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/exec/UpdateExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mariadb/MariadbEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mysql/MySQLEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/oracle/OracleEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/postgresql/PostgresqlEscapeHandler.java # rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.EscapeHandler # rm-datasource/src/test/java/io/seata/rm/datasource/ColumnUtilsTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/sql/handler/EscapeHandlerTest.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeHandler.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeSymbol.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/KeywordChecker.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/util/ColumnUtils.java

…-size-limit # Conflicts: # changes/en-us/2.0.0.md # changes/zh-cn/2.0.0.md

# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/exec/BaseTransactionalExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/exec/UpdateExecutor.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mariadb/MariadbEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/mysql/MySQLEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/oracle/OracleEscapeHandler.java # rm-datasource/src/main/java/io/seata/rm/datasource/sql/handler/postgresql/PostgresqlEscapeHandler.java # rm-datasource/src/main/resources/META-INF/services/io.seata.sqlparser.EscapeHandler # rm-datasource/src/test/java/io/seata/rm/datasource/ColumnUtilsTest.java # rm-datasource/src/test/java/io/seata/rm/datasource/sql/handler/EscapeHandlerTest.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeHandler.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/EscapeSymbol.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/KeywordChecker.java # sqlparser/seata-sqlparser-core/src/main/java/io/seata/sqlparser/util/ColumnUtils.java

funky-eyes

script folder in the config.txt, application.properties/yml, file.conf, and server example thatyml to add configuration, springboot-autoconfigure module to add the corresponding configuration examples

script文件夹中的config.txt,application.properties/yml，file.conf，和server的example那个yml要补充配置，springboot-autoconfigure模块要补充对应的配置示例

Bughue · 2023-11-09T06:47:44Z

script folder in the config.txt, application.properties/yml, file.conf, and server example thatyml to add configuration, springboot-autoconfigure module to add the corresponding configuration examples

script文件夹中的config.txt,application.properties/yml，file.conf，和server的example那个yml要补充配置，springboot-autoconfigure模块要补充对应的配置示例

DONE

common/src/main/java/io/seata/common/util/StringUtils.java

…-size-limit # Conflicts: # changes/en-us/2.0.0.md # changes/zh-cn/2.0.0.md

Bughue · 2023-11-23T03:19:03Z

文档更新 apache/incubator-seata-website#681

…-size-limit # Conflicts: # changes/en-us/2.0.0.md # changes/zh-cn/2.0.0.md

…-appdata-size-limit

funky-eyes

changelog需要移动到2.x.md中
Move the changelog to 2.x.md

...ver/src/main/java/io/seata/spring/boot/autoconfigure/properties/server/ServerProperties.java

server/src/main/java/io/seata/server/coordinator/AbstractCore.java

…-appdata-size-limit # Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md

funky-eyes

LGTM

funky-eyes reviewed Mar 29, 2022

View reviewed changes

server/src/main/java/io/seata/server/coordinator/AbstractCore.java Outdated Show resolved Hide resolved

funky-eyes added this to the 2.0.0 milestone Mar 29, 2022

funky-eyes added module/server server module type: optimize labels Mar 29, 2022

funky-eyes reviewed Mar 29, 2022

View reviewed changes

common/src/main/java/io/seata/common/DefaultValues.java Outdated Show resolved Hide resolved

funky-eyes reviewed Mar 29, 2022

View reviewed changes

rm/src/main/java/io/seata/rm/AbstractResourceManager.java Outdated Show resolved Hide resolved

funky-eyes reviewed Nov 4, 2023

View reviewed changes

rm/src/main/java/io/seata/rm/AbstractResourceManager.java Outdated Show resolved Hide resolved

funky-eyes reviewed Nov 4, 2023

View reviewed changes

server/src/main/java/io/seata/server/coordinator/AbstractCore.java Outdated Show resolved Hide resolved

Bughue changed the base branch from develop to 2.x November 6, 2023 07:44

Bughue changed the base branch from 2.x to develop November 6, 2023 07:49

app data size

9078442

Bughue changed the base branch from develop to 2.x November 6, 2023 08:35

Bughue force-pushed the dev-appdata-size-limit branch 2 times, most recently from 37ee18c to 9078442 Compare November 7, 2023 06:33

Bughue force-pushed the dev-appdata-size-limit branch from f661d34 to 2c6ab1b Compare November 7, 2023 07:45

Bughue changed the title ~~optimize : appdata size limit~~ optimize : rm appdata size limit Nov 7, 2023

Bughue force-pushed the dev-appdata-size-limit branch from 47f48e4 to 4177462 Compare November 7, 2023 08:23

Bughue added 4 commits November 7, 2023 16:28

Merge branch '2.x' of https://github.com/seata/seata into dev-appdata…

f66b089

…-size-limit # Conflicts: # changes/en-us/2.0.0.md # changes/zh-cn/2.0.0.md

Bughue force-pushed the dev-appdata-size-limit branch from 80dda91 to 2700d05 Compare November 9, 2023 02:32

funky-eyes reviewed Nov 9, 2023

View reviewed changes

application.example.yml

8c03d64

Bughue force-pushed the dev-appdata-size-limit branch from 367893b to 8c03d64 Compare November 9, 2023 06:43

Bughue force-pushed the dev-appdata-size-limit branch from c80d5ec to 110e55c Compare November 9, 2023 06:46

application.example.yml

bc22385

Bughue force-pushed the dev-appdata-size-limit branch from 21c6a55 to bc22385 Compare November 9, 2023 08:26

slievrly reviewed Nov 10, 2023

View reviewed changes

common/src/main/java/io/seata/common/util/StringUtils.java Outdated Show resolved Hide resolved

funky-eyes modified the milestones: 2.0.0, 2.x Backlog Nov 14, 2023

Merge branch '2.x' of https://github.com/seata/seata into dev-appdata…

5b63502

…-size-limit # Conflicts: # changes/en-us/2.0.0.md # changes/zh-cn/2.0.0.md

Bughue and others added 5 commits November 23, 2023 11:31

Merge branch '2.x' of https://github.com/seata/seata into dev-appdata…

dd6a77e

…-size-limit # Conflicts: # changes/en-us/2.0.0.md # changes/zh-cn/2.0.0.md

utf8

29eb7c7

import

c0aad05

Merge branch '2.x' into dev-appdata-size-limit

296006b

Merge remote-tracking branch 'origin/dev-appdata-size-limit' into dev…

6cabcdd

…-appdata-size-limit

Bughue mentioned this pull request Nov 27, 2023

optimize: add application data configuration items apache/incubator-seata-website#681

Merged

funky-eyes reviewed Nov 27, 2023

View reviewed changes

...ver/src/main/java/io/seata/spring/boot/autoconfigure/properties/server/ServerProperties.java Show resolved Hide resolved

server/src/main/java/io/seata/server/coordinator/AbstractCore.java Outdated Show resolved Hide resolved

funky-eyes and others added 4 commits November 27, 2023 17:45

Merge branch '2.x' into dev-appdata-size-limit

effda8c

changes and prop

2288eb1

Merge remote-tracking branch 'origin/dev-appdata-size-limit' into dev…

030a5bd

…-appdata-size-limit # Conflicts: # changes/en-us/2.x.md # changes/zh-cn/2.x.md

changes and prop

df1c0ad

funky-eyes modified the milestones: 2.x Backlog, 2.1.0 Nov 28, 2023

funky-eyes approved these changes Nov 28, 2023

View reviewed changes

funky-eyes added mode: TCC TCC transaction mode module/common common module module/script script module labels Nov 28, 2023

funky-eyes changed the title ~~optimize : rm appdata size limit~~ optimize: rm appdata size limit Nov 28, 2023

funky-eyes merged commit 9fef2db into apache:2.x Nov 28, 2023

open-digger-bot bot mentioned this pull request Dec 4, 2023

[WeeklyReport] Weekly report for seata 11/27/2023 to 12/4/2023 #6102

Closed

YvCeung pushed a commit to YvCeung/incubator-seata that referenced this pull request Dec 25, 2025

optimize: rm appdata size limit (apache#4473)

fd8d348

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

optimize: rm appdata size limit#4473

optimize: rm appdata size limit#4473
funky-eyes merged 20 commits intoapache:2.xfrom
Bughue:dev-appdata-size-limit

Bughue commented Mar 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Aug 25, 2022 •

edited by codecov bot

Loading

Uh oh!

CLAassistant commented Dec 12, 2022 •

edited

Loading

Uh oh!

CLAassistant commented Dec 12, 2022

Uh oh!

Uh oh!

Uh oh!

funky-eyes left a comment •

edited

Loading

Uh oh!

Bughue commented Nov 9, 2023

Uh oh!

Uh oh!

Bughue commented Nov 23, 2023

Uh oh!

funky-eyes left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

funky-eyes left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Bughue commented Mar 15, 2022

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Aug 25, 2022 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

CLAassistant commented Dec 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Dec 12, 2022

Uh oh!

Uh oh!

Uh oh!

funky-eyes left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Bughue commented Nov 9, 2023

Uh oh!

Uh oh!

Bughue commented Nov 23, 2023

Uh oh!

funky-eyes left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

funky-eyes left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-commenter commented Aug 25, 2022 •

edited by codecov bot

Loading

CLAassistant commented Dec 12, 2022 •

edited

Loading

funky-eyes left a comment •

edited

Loading

funky-eyes left a comment •

edited

Loading