[incubator-kie-issues #203] Cleanup Phreak code - Minor refactoring in SegmentMemory handling #6508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariofusco
reviewed
Oct 30, 2025
| public SegmentMemory getQuerySegmentMemory(QueryElementNode queryNode); | ||
|
|
||
| public void createChildSegments(LeftTupleSinkPropagator sinkProp, SegmentMemory smem); | ||
| public void initializeChildSegmentsIfNeeded(SegmentMemory smem); |
There was a problem hiding this comment.
Nitpic: I would remove the IfNeeded bit from the name of this method (unless you have a good reason to keep it).
There was a problem hiding this comment.
@mariofusco It is to clarify that the method is idempotent - you can call it twice and it won't get extra initailization.
mariofusco
reviewed
Oct 30, 2025
| .getLeftTupleSource().isStreamMode()); | ||
| List<PathMemory> pathsToFlush = LeftInputAdapterNode.doInsertSegmentMemory(wm, true, liaMem, memory.getSegmentMemory(), peer, node | ||
| .getLeftTupleSource().isStreamMode() ); | ||
| wm.getRuleNetworkEvaluator().forceFlushPaths(pathsToFlush); |
There was a problem hiding this comment.
Why is this force flush necessary now? Did it do this also before in a different way?
There was a problem hiding this comment.
@mariofusco yes. If you see the method called originally was doInsertSegmentMemoryWithFlush. Now it is doInsertSegmentMemory. See changes in LeftInputAdapterNode.
pibizza
changed the title
tkobayas
approved these changes
Oct 31, 2025
mariofusco
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces two improvements to segment memory handling: