Skip to content

Conversation

@yesamer
Copy link
Contributor

@yesamer yesamer commented Mar 14, 2024

Closes: apache/incubator-kie-issues#1008

In this PR:

In EvalHelper.compare method, a ClassCast exception is thrown when comparing some different subtypes of Number
(eg. BigDecimal vs Integer).
The fix's solution is to manage the Number in a separate branch and coerce both left and right parameters as BigDecimal before performing the comparison.
Another minor change I applied is to modify those if - else blocks to an early return blocks - Previously both styles were applied

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@yesamer yesamer requested review from baldimir and gitgabrio March 14, 2024 09:25
@yesamer yesamer merged commit aabf017 into apache:main Mar 15, 2024
@yesamer yesamer deleted the kie-issues#1008-2 branch March 15, 2024 08:48
yesamer added a commit to yesamer/drools that referenced this pull request Mar 18, 2024
* BigDecimal coerce operation

* BigDecimal coerce operation
yesamer added a commit to yesamer/drools that referenced this pull request Mar 18, 2024
* BigDecimal coerce operation

* BigDecimal coerce operation
yesamer added a commit to yesamer/drools that referenced this pull request Mar 18, 2024
* BigDecimal coerce operation

* BigDecimal coerce operation
yesamer added a commit to yesamer/drools that referenced this pull request Mar 18, 2024
* BigDecimal coerce operation

* BigDecimal coerce operation
yesamer added a commit to kiegroup/drools that referenced this pull request Mar 18, 2024
[7.67.x] [kie-issues#1008] Big Decimal data type conversion Issue (apache#5782)
yesamer added a commit to kiegroup/drools that referenced this pull request Mar 18, 2024
#35)

* BigDecimal coerce operation

* BigDecimal coerce operation
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Mar 27, 2024
* BigDecimal coerce operation

* BigDecimal coerce operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Big Decimal data type conversion Issue

3 participants