Skip to content

Conversation

@acezen
Copy link
Contributor

@acezen acezen commented Jan 26, 2024

Proposed changes

as title

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

close #344

@acezen acezen force-pushed the 344-update-test-path branch from e24c275 to a0e3066 Compare January 26, 2024 10:38
@Thespica
Copy link
Contributor

Sorry that I can't understand why Java SDK needs a specific test data, I think Java can also use the edge yaml after edited as long as GraphAr C++ 0.10.0 library can work correctly.

And technically, we should ensure the format is uniform, and not be affected by SDK.

@acezen
Copy link
Contributor Author

acezen commented Jan 27, 2024

Sorry that I can't understand why Java SDK needs a specific test data, I think Java can also use the edge yaml after edited as long as GraphAr C++ 0.10.0 library can work correctly.

And technically, we should ensure the format is uniform, and not be affected by SDK.

The GraphAr format has been change with PR-290 and we distract the property group from adj list in edge info and it's include in GraphAr v0.11.0. Currently, Java is binding 0.10.0, so here should be a java-for testing yaml until the java binding GraphAr update to v0.11.0

@acezen acezen merged commit 2b0395e into apache:main Jan 29, 2024
@acezen acezen deleted the 344-update-test-path branch January 29, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][C++]: Cannot read the edge property correctly

3 participants