IGNITE-26910 Handle unresolvable names in StaticNodeFinder #7188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpuch
reviewed
Dec 9, 2025
Contributor
rpuch
left a comment
rpuch
left a comment
There was a problem hiding this comment.
Let's also add an integration test
modules/api/src/main/java/org/apache/ignite/network/NetworkAddress.java
Outdated
Show resolved
Hide resolved
modules/network/src/main/java/org/apache/ignite/internal/network/StaticNodeFinder.java
Outdated
Show resolved
Hide resolved
modules/network/src/main/java/org/apache/ignite/internal/network/StaticNodeFinder.java
Outdated
Show resolved
Hide resolved
modules/network/src/main/java/org/apache/ignite/internal/network/StaticNodeFinder.java
Outdated
Show resolved
Hide resolved
rpuch
reviewed
Dec 11, 2025
modules/api/src/main/java/org/apache/ignite/network/NetworkAddress.java
Outdated
Show resolved
Hide resolved
...work/src/integrationTest/java/org/apache/ignite/internal/network/ItStaticNodeFinderTest.java
Show resolved
Hide resolved
...work/src/integrationTest/java/org/apache/ignite/internal/network/ItStaticNodeFinderTest.java
Outdated
Show resolved
Hide resolved
modules/network/src/main/java/org/apache/ignite/internal/network/StaticNodeFinder.java
Outdated
Show resolved
Hide resolved
# Conflicts: # modules/network/build.gradle
rpuch
reviewed
Dec 16, 2025
...work/src/integrationTest/java/org/apache/ignite/internal/network/ItStaticNodeFinderTest.java
Outdated
Show resolved
Hide resolved
...work/src/integrationTest/java/org/apache/ignite/internal/network/ItStaticNodeFinderTest.java
Outdated
Show resolved
Hide resolved
modules/network/src/main/java/org/apache/ignite/internal/network/StaticNodeFinder.java
Outdated
Show resolved
Hide resolved
rpuch
approved these changes
Dec 17, 2025
rpuch
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-26910