Skip to content

Conversation

@korlov42
Copy link
Contributor

@korlov42 korlov42 commented Dec 8, 2025

https://issues.apache.org/jira/browse/IGNITE-26634


Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

The Review Checklist

  • Formal criteria: TC status, codestyle, mandatory documentation. Also make sure to complete the following:
    - There is a single JIRA ticket related to the pull request.
    - The web-link to the pull request is attached to the JIRA ticket.
    - The JIRA ticket has the Patch Available state.
    - The description of the JIRA ticket explains WHAT was made, WHY and HOW.
    - The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • Design: new code conforms with the design principles of the components it is added to.
  • Patch quality: patch cannot be split into smaller pieces, its size must be reasonable.
  • Code quality: code is clean and readable, necessary developer documentation is added if needed.
  • Tests code quality: test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

Notes

@korlov42 korlov42 force-pushed the ignite-26634 branch 3 times, most recently from ef52ae3 to f7b78f2 Compare December 9, 2025 08:28
@korlov42 korlov42 merged commit a5f7c91 into apache:main Dec 11, 2025
5 checks passed
@korlov42 korlov42 deleted the ignite-26634 branch December 11, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants