Skip to content

Conversation

@xloya
Copy link
Contributor

@xloya xloya commented Sep 22, 2022

Port zorder strategy (#3983) and generate binary/fixed literals (#3728) to Spark 3.1, the reason for the merged port is that Zorder's tests rely on the fix in patch #3728

@github-actions github-actions bot added the spark label Sep 22, 2022
@xloya
Copy link
Contributor Author

xloya commented Sep 22, 2022

@rdblue
Copy link
Contributor

rdblue commented Sep 24, 2022

@xloya, can you separate backports into individual PRs, please?

@xloya
Copy link
Contributor Author

xloya commented Sep 24, 2022

@xloya, can you separate backports into individual PRs, please?

Sure, but the unit tests of the patch of #3983 (Zorder strategy) would not pass until the patch of #3728 (Generate Binary/Fixed literals) is merged. When #3728 is merged, I will rebase to the backport patch of #3983

@xloya
Copy link
Contributor Author

xloya commented Sep 24, 2022

@rdblue Already seperate them to #5847 and #5848, please review again when you have time, thx!

@ajantha-bhat
Copy link
Member

Closing this PR as spark-3.1 module is removed from master code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants