AWS: swapping s3 aal to the sync client and adding aal vector path

[stubz151]

What Am I doing

Removing the async client which AAL added in pr's:

reverting the majority of:
#12553
#12299

I am doing this because after testing/benchmarking and speaking with the teams involved, this is not a suitable use-case for the s3 async client so I am removing it.

I am also implementing the range readable interface on the AAL adapter to make better use of the new api's we have added.

How have I tested it

• benchmarked
• unit tests
• integration tests

[singhpk234]

Thank you for the change @stubz151

Since these are removing public interfaces directly, wondering if we should mark them deprecated first ? and set a version where we want them to get removed.

Also curious, if you can share benchmarks you sighted above.

[fuatbasik]

Hi @singhpk234. Thanks a lot for your comments. @stubz151 is out of office but I can answer your questions until he is back.

Since these are removing public interfaces directly, wondering if we should mark them deprecated first ? and set a version where we want them to get removed.

AFAIK these interfaces currently only used by AnalyticsStream. They were added when we initially added the stream but during the community sync at 8/27 there were concerns about the developer experience. If you still think we should deprecate them first, happy to do it.

Also curious, if you can share benchmarks you sighted above.

We recently added sync client to our microbenchmarks: https://github.com/awslabs/analytics-accelerator-s3/tree/main/input-stream/src/jmh and havent seen much difference between sync and async client. This is mostly because Analytics Accelerator already handles async logic itself, so no need for additional client complexity. It will still support Async client though, for users who are already in Async client. But as initially we introduced Async client. Following aforementioned community feedback about developer experince, we though we can remove Async client integration from Iceberg.

[github-actions]

This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions.

[github-actions]

This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.