Skip to content

chore: use ninja for ci build#215

Merged
Fokko merged 1 commit into
apache:mainfrom
zhjwpku:use_ninja
Sep 7, 2025
Merged

chore: use ninja for ci build#215
Fokko merged 1 commit into
apache:mainfrom
zhjwpku:use_ninja

Conversation

@zhjwpku

@zhjwpku zhjwpku commented Sep 7, 2025

Copy link
Copy Markdown
Collaborator

Our CI runs quite slow, especially on windows, I observed task being terminated when it hit 30 minutes, not sure if that's the limit of gh actions.

By using Ninja build, CI goes a lot faster, in general, it can save us more that 10 minutes in general. For specific jobs, below are some numbers(unit minutes):

  • ASAN 18 -> 7
  • Cpp linter 17 -> 7
  • Test Mac 13 -> 5
  • Test Ubuntu 17 -> 7
  • Test Windows 29 -> 17

@wgtmac wgtmac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Thanks a lot @zhjwpku!

cc @HuaHuaY as you have observed the same issue last week.

@Fokko Fokko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is great! This is especially helpful for first time contributors where we have to trigger the CI. Thanks @zhjwpku for working on this, and thanks @wgtmac for the review 🙌

@Fokko Fokko merged commit 78d06bf into apache:main Sep 7, 2025
7 checks passed
@zhjwpku zhjwpku deleted the use_ninja branch September 7, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants