feat: implement endian conversion utilities#196
Conversation
|
|
||
| /// \brief Concept for values that can be converted to/from another endian format. | ||
| template <typename T> | ||
| concept EndianConvertible = std::is_arithmetic_v<T> && !std::same_as<T, bool>; |
There was a problem hiding this comment.
Sizeof(bool) is 1 byte, and endianness is irrelevant for single-byte data types; a byte-swap is a no-op.
Also, according to the Iceberg specification, a boolean is represented as 0x00 for false and any non-zero byte for true. This definition is inherently independent of endianness, which is different from multi-byte types like int or double, where the specification explicitly defines the value as being stored in a particular endian format .
There was a problem hiding this comment.
What about char? There is a sizeof(T) <= 1 branch, so maybe treat bool the same.
There was a problem hiding this comment.
What about char? There is a
sizeof(T) <= 1branch, so maybe treat bool the same.
I see your point, but I think performing an endian conversion on a bool is semantically less reasonable. The main benefit of the current design is that it explicitly catches this kind of logical error at compile time.
There was a problem hiding this comment.
If we don't support bool here, users may need to special case bool to avoid passing it to ByteSwap. For simplicity, should we support bool as well?
HeartLinked
force-pushed
the
endian
branch
2 times, most recently
from
cffc99f to
8fa1e09
Compare
|
|
||
| /// \brief Concept for values that can be converted to/from another endian format. | ||
| template <typename T> | ||
| concept EndianConvertible = std::is_arithmetic_v<T> && !std::same_as<T, bool>; |
There was a problem hiding this comment.
If we don't support bool here, users may need to special case bool to avoid passing it to ByteSwap. For simplicity, should we support bool as well?
|
@wgtmac I've updated the code to address the feedback from the review. Thank you. |
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks for adding this @HeartLinked, and thanks for the review all! 🙌
5 participants
Implements cross-platform endianness conversion utilities in
src/iceberg/util/endian.hwith full support for integer and floating-point types, including comprehensive test coverage.