Skip to content

[HUDI-5289] Fix writeStatus RDD recalculated in cluster #7373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Zouxxyy wants to merge 2 commits into from
Closed

[HUDI-5289] Fix writeStatus RDD recalculated in cluster #7373

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a683b28
[HUDI-5289] Fix writeStatus RDD recalculated in cluster
Zouxxyy Dec 3, 2022
5f13f4c
persist writeStatusRDD
Zouxxyy Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ava/org/apache/hudi/client/clustering/run/strategy/MultipleSparkJobExecutionStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
import org.apache.spark.sql.Row;
import org.apache.spark.sql.SQLContext;
import org.apache.spark.sql.sources.BaseRelation;
import org.apache.spark.storage.StorageLevel;

import java.io.IOException;
import java.util.ArrayList;
Expand Down Expand Up @@ -122,6 +123,8 @@ public HoodieWriteMetadata<HoodieData<WriteStatus>> performClustering(final Hood
.stream();
JavaRDD<WriteStatus>[] writeStatuses = convertStreamToArray(writeStatusesStream.map(HoodieJavaRDD::getJavaRDD));
JavaRDD<WriteStatus> writeStatusRDD = engineContext.union(writeStatuses);
// Persist writeStatus, since it may be reused
writeStatusRDD.persist(StorageLevel.MEMORY_AND_DISK());
Copy link
Contributor

@nsivabalan nsivabalan Dec 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't rely on cache since cache could be invalidated and we have had experiences where actual files written did not match w/ whats in writeStatus. Hence if something fails, we let dag to get retriggered here. we added guard rails at BasecommitActionExecutor by means of cloning.
CC @alexeykudinkin


HoodieWriteMetadata<HoodieData<WriteStatus>> writeMetadata = new HoodieWriteMetadata<>();
writeMetadata.setWriteStatuses(HoodieJavaRDD.of(writeStatusRDD));
Expand Down