Skip to content

[HUDI-5097] Fix partition reading without partition fields table config #7069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeykudinkin merged 1 commit into from
Dec 15, 2022
Merged

[HUDI-5097] Fix partition reading without partition fields table config #7069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions hudi-common/src/main/java/org/apache/hudi/BaseHoodieTableFileIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ protected List<PartitionPath> getAllQueryPartitionPaths() {

// Load all the partition path from the basePath, and filter by the query partition path.
// TODO load files from the queryRelativePartitionPaths directly.
List<String> matchedPartitionPaths = getAllPartitionPathsUnchecked()
List<String> matchedPartitionPaths = FSUtils.getAllPartitionPaths(engineContext, metadataConfig, basePath.toString())
.stream()
.filter(path -> queryRelativePartitionPaths.stream().anyMatch(path::startsWith))
.collect(Collectors.toList());
Expand Down Expand Up @@ -331,14 +331,6 @@ private Map<String, FileStatus[]> getAllFilesInPartitionsUnchecked(Collection<St
}
}

private List<String> getAllPartitionPathsUnchecked() {
try {
return isPartitionedTable() ? tableMetadata.getAllPartitionPaths() : Collections.singletonList("");
} catch (IOException e) {
throw new HoodieIOException("Failed to fetch partition paths for a table", e);
}
}

private void validate(HoodieTimeline activeTimeline, Option<String> queryInstant) {
if (shouldValidateInstant) {
if (queryInstant.isPresent() && !activeTimeline.containsInstant(queryInstant.get())) {
Expand Down Expand Up @@ -366,10 +358,6 @@ private void resetTableMetadata(HoodieTableMetadata newTableMetadata) {
tableMetadata = newTableMetadata;
}

private boolean isPartitionedTable() {
return partitionColumns.length > 0 || HoodieTableMetadata.isMetadataTable(basePath.toString());
}

public static final class PartitionPath {

final String path;
Expand Down