Skip to content

[HUDI-5087] Fix incorrect merging sequence for Column Stats Record in HoodieMetadataPayload #7053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeykudinkin merged 4 commits into from
Oct 26, 2022
Merged

[HUDI-5087] Fix incorrect merging sequence for Column Stats Record in HoodieMetadataPayload #7053

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7a6d240
[HUDI-5087]Fix incorrect maxValue getting from metatable
Zhangshunyu Oct 25, 2022
670eaec
Fixed `HoodieMetadataPayload` merging seq;
Oct 25, 2022
8bf2750
Fixing handling of deletes;
Oct 25, 2022
6ce0ce0
Added tests for combining partition files-list record
Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hudi-common/src/main/java/org/apache/hudi/metadata/HoodieMetadataPayload.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,8 +639,8 @@ private static HoodieMetadataColumnStats mergeColumnStatsRecords(HoodieMetadataC

Comparable maxValue =
(Comparable) Stream.of(
(Comparable) unwrapStatisticValueWrapper(prevColumnStats.getMinValue()),
(Comparable) unwrapStatisticValueWrapper(newColumnStats.getMinValue()))
(Comparable) unwrapStatisticValueWrapper(prevColumnStats.getMaxValue()),
(Comparable) unwrapStatisticValueWrapper(newColumnStats.getMaxValue()))
Copy link
Contributor

@danny0405 danny0405 Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, is there any possibility we write a unit test for this clazz ?

Copy link
Contributor

@nsivabalan nsivabalan Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@alexeykudinkin alexeykudinkin Oct 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the tests

.filter(Objects::nonNull)
.max(Comparator.naturalOrder())
.orElse(null);
Expand Down