Skip to content

[HUDI-5038] Increase default num_instants to fetch for incremental source #6955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsivabalan merged 2 commits into from
Oct 25, 2022
Merged

[HUDI-5038] Increase default num_instants to fetch for incremental source #6955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5b8ef0
[HUDI-5038] Increase default num_instants to fetch for incremental so…
yihua Oct 15, 2022
1dade48
Fix test
yihua Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/HoodieIncrSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public static class Config {
* {@value #NUM_INSTANTS_PER_FETCH} allows the max number of instants whose changes can be incrementally fetched.
*/
static final String NUM_INSTANTS_PER_FETCH = "hoodie.deltastreamer.source.hoodieincr.num_instants";
static final Integer DEFAULT_NUM_INSTANTS_PER_FETCH = 1;
static final Integer DEFAULT_NUM_INSTANTS_PER_FETCH = 5;

/**
* {@value #HOODIE_SRC_PARTITION_FIELDS} specifies partition fields that needs to be added to source table after
Expand Down
3 changes: 3 additions & 0 deletions ...utilities/src/test/java/org/apache/hudi/utilities/functional/TestHoodieDeltaStreamer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2101,6 +2101,7 @@ public void testHoodieIncrFallback() throws Exception {
HoodieDeltaStreamer.Config downstreamCfg =
TestHelpers.makeConfigForHudiIncrSrc(tableBasePath, downstreamTableBasePath,
WriteOperationType.BULK_INSERT, true, null);
downstreamCfg.configs.add("hoodie.deltastreamer.source.hoodieincr.num_instants=1");
new HoodieDeltaStreamer(downstreamCfg, jsc).sync();

insertInTable(tableBasePath, 9, WriteOperationType.UPSERT);
Expand All @@ -2112,6 +2113,8 @@ public void testHoodieIncrFallback() throws Exception {
downstreamCfg.configs = new ArrayList<>();
}

// Remove source.hoodieincr.num_instants config
downstreamCfg.configs.remove(downstreamCfg.configs.size() - 1);
downstreamCfg.configs.add(DataSourceReadOptions.INCREMENTAL_FALLBACK_TO_FULL_TABLE_SCAN_FOR_NON_EXISTING_FILES().key() + "=true");
//Adding this conf to make testing easier :)
downstreamCfg.configs.add("hoodie.deltastreamer.source.hoodieincr.num_instants=10");
Expand Down