Skip to content

[HUDI-4902] Set default partitioner for SIMPLE BUCKET index #6759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsivabalan merged 4 commits into from
Sep 26, 2022
Merged

[HUDI-4902] Set default partitioner for SIMPLE BUCKET index #6759

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01ce4c8
[HUDI-4902] Set default partitioner for SIMPLE BUCKET index
xicm Sep 23, 2022
f91c177
remove unneccessary if condition
xicm Sep 23, 2022
3c0284e
add ut testSimpleBucketIndexDefaultPartitionerConfig
xicm Sep 24, 2022
74953bc
update ut
xicm Sep 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieLayoutConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ public class HoodieLayoutConfig extends HoodieConfig {
.noDefaultValue()
.withDocumentation("Partitioner class, it is used to distribute data in a specific way.");

private static final String SIMPLE_BUCKET_LAYOUT_PARTITIONER_CLASS_NAME =
"org.apache.hudi.table.action.commit.SparkBucketIndexPartitioner";

private HoodieLayoutConfig() {
super();
}
Expand Down Expand Up @@ -80,8 +83,15 @@ public HoodieLayoutConfig build() {
}

private void setDefault() {
if (layoutConfig.contains(HoodieIndexConfig.INDEX_TYPE.key()) && layoutConfig.getString(HoodieIndexConfig.INDEX_TYPE.key()).equals(HoodieIndex.IndexType.BUCKET.name())) {
if (layoutConfig.contains(HoodieIndexConfig.INDEX_TYPE.key())
&& layoutConfig.getString(HoodieIndexConfig.INDEX_TYPE.key()).equals(HoodieIndex.IndexType.BUCKET.name())) {
layoutConfig.setDefaultValue(LAYOUT_TYPE, HoodieStorageLayout.LayoutType.BUCKET.name());

// Currently, the partitioner of the SIMPLE bucket index is supported by SparkBucketIndexPartitioner only.
if (layoutConfig.contains(HoodieIndexConfig.BUCKET_INDEX_ENGINE_TYPE)
&& layoutConfig.getString(HoodieIndexConfig.BUCKET_INDEX_ENGINE_TYPE).equals("SIMPLE")) {
Copy link
Contributor

@yihua yihua Sep 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can be simplified as "SIMPLE".equals(layoutConfig.getString(HoodieIndexConfig.BUCKET_INDEX_ENGINE_TYPE)) without the contains check.

layoutConfig.setDefaultValue(LAYOUT_PARTITIONER_CLASS_NAME, SIMPLE_BUCKET_LAYOUT_PARTITIONER_CLASS_NAME);
}
}
layoutConfig.setDefaultValue(LAYOUT_TYPE, LAYOUT_TYPE.defaultValue());
}
Expand Down