Skip to content

[HUDI-4880] Fix corrupted parquet file issue left by a leaked thread in CompactFunction #6733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 1 commit into from
Nov 3, 2022
Merged

[HUDI-4880] Fix corrupted parquet file issue left by a leaked thread in CompactFunction #6733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...tasource/hudi-flink/src/main/java/org/apache/hudi/sink/clustering/ClusteringOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,10 @@ public void processElement(StreamRecord<ClusteringPlanEvent> element) throws Exc
}

@Override
public void close() {
public void close() throws Exception {
if (null != this.executor) {
this.executor.close();
}
if (this.writeClient != null) {
this.writeClient.cleanHandlesGracefully();
this.writeClient.close();
Expand Down
12 changes: 12 additions & 0 deletions ...ink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,4 +133,16 @@ private HoodieWriteConfig reloadWriteConfig() throws Exception {
public void setExecutor(NonThrownExecutor executor) {
this.executor = executor;
}

@Override
public void close() throws Exception {
if (null != this.executor) {
this.executor.close();
Copy link
Contributor

@danny0405 danny0405 Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.asyncCompaction -> this.executor != null

Copy link
Contributor

@danny0405 danny0405 Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we can fix the ClusteringOperator#close as well.

Copy link
Contributor Author

@TengHuo TengHuo Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, good idea

Copy link
Contributor Author

@TengHuo TengHuo Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

}
if (null != this.writeClient) {
this.writeClient.cleanHandlesGracefully();
this.writeClient.close();
this.writeClient = null;
}
}
}