Skip to content

[HUDI-4780] hoodie.logfile.max.size It does not take effect, causing the log file to be too large #6602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 14 commits into from
Sep 15, 2022
Merged

[HUDI-4780] hoodie.logfile.max.size It does not take effect, causing the log file to be too large #6602

Changes from 11 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ee9ae14
Merge pull request #1 from apache/master
loukey-lj Jan 26, 2021
3fb10f7
Merge branch 'apache:master' into master
loukey-lj May 30, 2021
0fa6348
Merge branch 'apache:master' into master
loukey-lj Feb 16, 2022
9427b43
Merge branch 'apache:master' into master
loukey-lj Feb 17, 2022
99bf8f2
Merge branch 'apache:master' into master
loukey-lj Feb 17, 2022
83f0414
Merge branch 'apache:master' into master
loukey-lj May 17, 2022
fb01262
Merge branch 'apache:master' into master
loukey-lj May 22, 2022
e1dfa9d
Merge branch 'apache:master' into master
loukey-lj Jun 15, 2022
c35a685
Merge branch 'apache:master' into master
loukey-lj Aug 25, 2022
05caed5
Merge branch 'apache:master' into master
loukey-lj Sep 5, 2022
8dad0d3
hoodie.logfile.max.size It does not take effect, causing the log file…
Sep 5, 2022
9134561
hoodie.logfile.max.size It does not take effect, causing the log file…
Sep 9, 2022
4184522
Merge branch 'HUDI-4780' of https://github.com/loukey-lj/hudi into HU…
Sep 9, 2022
cc8badb
hoodie.logfile.max.size It does not take effect, causing the log file…
Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFormatWriter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ public long getCurrentSize() throws IOException {
if (output == null) {
return 0;
}
return output.getPos();
return output.getPos() + logFile.getFileSize();
Copy link
Contributor

@yihua yihua Sep 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loukey-lj Could you explain how this affects the size calculation? Should output.getPos() return the size written already?

Copy link
Contributor Author

@loukey-lj loukey-lj Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yihua When appending data to an old log file,org.apache.hudi.common.table.log.HoodieLogFormatWriter#getOutputStream postition always start at 0, after flush, org.apache.hudi.common.table.log.HoodieLogFormatWriter#getCurrentSize returned result is the size of the append dataset, not the total size of the entire file. u can debug follow code.

StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
env.enableCheckpointing(1000 * 20);
env.setParallelism(1);

    StreamTableEnvironment tableEnvironment = StreamTableEnvironment.create(env);
    final DataStreamSource<Tuple3<String, Long, Long>> tuple3DataStreamSource = env.addSource(new SourceFunction<Tuple3<String, Long, Long>>() {
        @Override
        public void run(SourceContext<Tuple3<String, Long, Long>> ctx) throws Exception {
            while (!Thread.interrupted()){
                ctx.collect(new Tuple3<>("1",System.currentTimeMillis(), System.currentTimeMillis()));
                Thread.sleep(1000 * 10 );
            }
        }
        @Override
        public void cancel() {
        }
    });

    tableEnvironment.createTemporaryView("s", tuple3DataStreamSource);

    tableEnvironment.executeSql("\n" +
                    "\n" +
                    "create table if not exists h(\n" +
                    "  `id` string PRIMARY KEY NOT ENFORCED , \n" +
                    "  `ts` bigint , \n" +
                    "  `time` bigint \n" +
                    ") \n" +
                    "with (\n" +
                    "\t'connector' = 'hudi',\n 'write.bucket_assign.tasks'='1', " +
                    "\t'hoodie.datasource.write.keygenerator.class'='org.apache.hudi.keygen.SimpleAvroKeyGenerator',\n" +
                    "\t'table.type' = 'MERGE_ON_READ',\n" +
                    "\t'hive_sync.enable' = 'false',\n" +
                    "\t'write.tasks'='1',\n" +
                    "\t'path' = 'hdfs://xx',\n" +
                    "\t'hoodie.cleaner.commits.retained' = '1'\n" +
     ")\n");

    tableEnvironment.executeSql("insert into h  SELECT * from s \n");

Copy link
Contributor

@yihua yihua Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loukey-lj Got it. This is a HDFS-specific problem.

}

/**
Expand Down