Skip to content
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
353d9b6
pr title and comment validation
Sep 2, 2022
140189a
should work when edited
Sep 2, 2022
1600e31
check didn't run, hope this fixes
Sep 2, 2022
b1bf6ad
going back to how it was before
Sep 2, 2022
4d02f2c
adding some debugging to env vars
Sep 2, 2022
9f5bcdb
was setting the title env var to be the body. dumb typo
Sep 2, 2022
48147d1
getting rid of env vars because they didn't persist
Sep 2, 2022
a7a693c
this might fix the issue
Sep 2, 2022
0cb0b8f
capitalization on risk level doesn't matter now
Sep 2, 2022
c644d73
reducing title constraint so that the minimum number of digits is now 1
Sep 7, 2022
a2f8065
update test to reflect changes
Sep 15, 2022
a0d748b
current progress
Sep 19, 2022
6070ef9
trying to show error message
Sep 28, 2022
0e2333d
Merge branch 'apache:master' into inspect_pr_compliance
jonvex Sep 28, 2022
fe610b4
fixed typo
Sep 28, 2022
64ea13e
fixed typo
Sep 28, 2022
242f21c
addressed all found bugs
Sep 28, 2022
8977c6c
try to get error message to work
Sep 28, 2022
76ad961
testing template edit
Sep 29, 2022
b524fcc
fixed bash error
Sep 29, 2022
3f2440a
still trying to get template edit check to work
Sep 29, 2022
3ef2ca8
still having git issue
Sep 29, 2022
892ca08
disable on pr for faster testing
Sep 29, 2022
8bf172f
next try
Sep 29, 2022
5dfc76a
another try
Sep 29, 2022
17bb02d
another try
Sep 29, 2022
17d2908
another try
Sep 29, 2022
bba74fe
reverted change
Sep 29, 2022
00cd7e6
actually reverted change
Sep 29, 2022
51979ee
give a better error message
Sep 29, 2022
7e3c8e9
finished writing the testing
Oct 3, 2022
5e363b5
got rid of documentation from parsing
Oct 6, 2022
580379d
updated readme
Oct 6, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#How to update the Pull Request Template
When updating the pr template, you must consider if updates need to be made to scripts/pr_compliance.py
4 changes: 4 additions & 0 deletions .github/workflows/bot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
branches:
- master
- 'release-*'
paths-ignore:
- '.github/**'
- '**.md'
- '**.py'
env:
MVN_ARGS: -ntp -B -V -Pwarn-log -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.shade=warn -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugins.dependency=warn

Expand Down
21 changes: 21 additions & 0 deletions .github/workflows/pr_compliance.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: validate pr
on:
pull_request:
types: [opened, edited, reopened, synchronize]
branches:
- master

jobs:
validate-pr:
runs-on: ubuntu-latest
env:
REQUEST_BODY: ${{ github.event.pull_request.body }}
REQUEST_TITLE: ${{ github.event.pull_request.title }}
steps:
- uses: actions/checkout@v3
- uses: actions/setup-python@v3
- name: run script
run: python scripts/pr_compliance.py > test.log || { echo "::error::pr_compliance.py $(cat test.log)" && exit 1; }



19 changes: 19 additions & 0 deletions .github/workflows/update_template.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Update Template

on:
pull_request:
types: [opened, edited, reopened, synchronize]
branches:
- master
paths:
- .github/PULL_REQUEST_TEMPLATE.md

jobs:
check-script:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: ensure script is updated
run: git diff --name-only remotes/origin/master HEAD | grep -c scripts/pr_compliance.py || { echo "::error::PULL_REQUEST_TEMPLATE.md scripts/pr_compliance.py not updated" && exit 1; }
Loading