Skip to content

[HUDI-4730] Fix batch job cannot clean old commits files #6515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 6 commits into from
Aug 30, 2022
Merged

[HUDI-4730] Fix batch job cannot clean old commits files #6515

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2875f86
[HUDI-4370] FIX Batch job cannot clean old commits&data files in clea…
Aug 27, 2022
bf717b4
[HUDI-4370] minor update
Aug 27, 2022
8941b53
Revert "[HUDI-4370] minor update"
Aug 27, 2022
8950572
Revert "[HUDI-4370] FIX Batch job cannot clean old commits&data files…
Aug 27, 2022
eea3ff0
[HUDI-4730] minor update
Aug 27, 2022
90f411c
[HUDI-4730] minor update
Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,12 @@ private FlinkOptions() {
.defaultValue(true)
.withDescription("Whether to cleanup the old commits immediately on new commits, enabled by default");

public static final ConfigOption<Boolean> BATCH_CLEAN_ENABLED = ConfigOptions
.key("clean.batch.enabled")
.booleanType()
.defaultValue(false)
.withDescription("Whether to clean the old commits when initial clean function， should only set to true when job is in batch mode");

public static final ConfigOption<String> CLEAN_POLICY = ConfigOptions
.key("clean.policy")
.stringType()
Expand Down
2 changes: 1 addition & 1 deletion hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/CleanFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public void open(Configuration parameters) throws Exception {
this.writeClient = StreamerUtil.createWriteClient(conf, getRuntimeContext());
this.executor = NonThrownExecutor.builder(LOG).waitForTasksFinish(true).build();

if (OptionsResolver.isInsertOverwrite(conf)) {
if (OptionsResolver.isInsertOverwrite(conf) || conf.getBoolean(FlinkOptions.BATCH_CLEAN_ENABLED)) {
String instantTime = HoodieActiveTimeline.createNewInstantTime();
LOG.info(String.format("exec sync clean with instant time %s...", instantTime));
executor.execute(() -> writeClient.clean(instantTime), "wait for sync cleaning finish");
Expand Down