Skip to content

[HUDI-4259] Flink create avro schema not conformance to standards #5878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 10 commits into from
Jun 20, 2022
Merged

[HUDI-4259] Flink create avro schema not conformance to standards #5878

Changes from 9 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ee9ae14
Merge pull request #1 from apache/master
loukey-lj Jan 26, 2021
3fb10f7
Merge branch 'apache:master' into master
loukey-lj May 30, 2021
0fa6348
Merge branch 'apache:master' into master
loukey-lj Feb 16, 2022
9427b43
Merge branch 'apache:master' into master
loukey-lj Feb 17, 2022
99bf8f2
Merge branch 'apache:master' into master
loukey-lj Feb 17, 2022
83f0414
Merge branch 'apache:master' into master
loukey-lj May 17, 2022
fb01262
Merge branch 'apache:master' into master
loukey-lj May 22, 2022
e1dfa9d
Merge branch 'apache:master' into master
loukey-lj Jun 15, 2022
0094102
flink create avro schema not conformance to standards
Jun 15, 2022
d1a7987
flink create avro schema not conformance to standards
Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/AvroSchemaConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ public static Schema convertToSchema(LogicalType logicalType, String rowName) {
LogicalType fieldType = rowType.getTypeAt(i);
SchemaBuilder.GenericDefault<Schema> fieldBuilder =
builder.name(fieldName)
.type(convertToSchema(fieldType, rowName + "_" + fieldName));
.type(convertToSchema(fieldType, rowName + "." + fieldName));
Copy link
Contributor

@danny0405 danny0405 Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment in line 174 should also be tweaked.


if (fieldType.isNullable()) {
builder = fieldBuilder.withDefault(null);
Expand Down