Skip to content

[HUDI-4053] Flaky ITTestHoodieDataSource.testStreamWriteBatchReadOpti… #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny0405 merged 2 commits into from
May 9, 2022
Merged

[HUDI-4053] Flaky ITTestHoodieDataSource.testStreamWriteBatchReadOpti… #5526

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b9f943
[HUDI-4053] Flaky ITTestHoodieDataSource.testStreamWriteBatchReadOpti…
May 7, 2022
d585128
apply danny0405's patch
May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...ink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,7 +1358,11 @@ private List<Row> execSelectSql(TableEnvironment tEnv, String select, String sin
TableResult tableResult = tEnv.executeSql("insert into sink " + select);
// wait for the timeout then cancels the job
TimeUnit.SECONDS.sleep(timeout);
tableResult.getJobClient().ifPresent(JobClient::cancel);
try {
tableResult.getJobClient().ifPresent(JobClient::cancel);
} catch (IllegalStateException e) {
log.info("MiniCluster has already been shut down, do nothing.");
}
Copy link
Contributor

@danny0405 danny0405 May 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @xicm ! I have applied your patch but it does not solve the problem.

Actually the test is flaky because in recent change:

hudi/hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactionPlanOperator.java

Line 112 in 52fe1c9

if (firstInflight.isPresent()) {

We have tweaked the compaction scheduling strategy: when there is a pending compaction, we can not schedule another one, the test is flaky based on whether there is pending compaction when scheduling.

My initial idea is we change the test itself:
4053.patch.zip
Hope it helps, or maybe you have better idea :)

Copy link
Contributor Author

@xicm xicm May 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't go into this test. my changes is not the root cause, let me close this pr and you push your patch.

Copy link
Contributor Author

@xicm xicm May 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the testWriteAndReadDebeziumJson is flaky a few days ago,it resolved with my changes. But I haven't reproduced it today. It seems I haven't found the root cause.

tEnv.executeSql("DROP TABLE IF EXISTS sink");
return CollectSinkTableFactory.RESULT.values().stream()
.flatMap(Collection::stream)
Expand Down