[HUDI-3947] Fixing Hive conf usage in HoodieSparkSqlWriter #5401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
commented
Apr 22, 2022
|
|
||
| syncClientToolClassSet.foreach(impl => { | ||
| SyncUtilHelpers.runHoodieMetaSync(impl.trim, properties, hiveConf, fs, basePath.toString, baseFileFormat) | ||
| SyncUtilHelpers.runHoodieMetaSync(impl.trim, properties, fs.getConf, fs, basePath.toString, baseFileFormat) |
Contributor
Author
There was a problem hiding this comment.
Note to reviewer: Initially thought of adding docs here. but HiveConf is not really required, bcoz SyncUtilHelpers.runHoodieMetaSync() expects only HadoopConf as 3rd argument. So, didn't feel a need to add docs around the fix.
alexeykudinkin
approved these changes
Apr 22, 2022
nsivabalan
force-pushed
the
spark2Scala12Fix
branch
from
bf0a868 to
f3c88b4
Compare
Contributor
Author
|
@hudi-bot run azure |
xushiyan
pushed a commit
that referenced
this pull request
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
HiveConf is getting eagerly loaded when HoodieSparkSqlWriter is touched. Strangely this happens only with spark2 and scala12 and not w/ any other profiles. And after inspecting the usages, looks like we don't really need to use HiveConfig in HoodieSparkSqlWriter, all we need is HadoopConf. So, have fixed the usage.
Brief change log
Verify this pull request
This pull request is already covered by existing tests.
Ran quick start locally and verified that w/ the patch, it succeeds. and w/o the patch, we get failure w/ spark2 and scala12.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.