[HUDI-3948] Fix presto bundle missing HBase classes #5398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihua
force-pushed
the
HUDI-3948-fix-presto-bundle
branch
from
ca26692 to
2bcba4a
Compare
yihua
changed the title
yihua
force-pushed
the
HUDI-3948-fix-presto-bundle
branch
from
2bcba4a to
56b7136
Compare
yihua
changed the title
Contributor
Author
|
@hudi-bot run azure |
codope
approved these changes
Apr 23, 2022
Member
|
This has bloated the hudi-presto-bundle size (now it's ~33mb almost 2x). But, let's land this now and work on optimizung the bundle later. HUDI-3956 to track it. |
xushiyan
pushed a commit
that referenced
this pull request
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
This PR adds the missing artifact of
hbase-serverandcommons-lang3and removes unusedhbase-protocolin presto bundle. This PR also removeshbase-annotations(only test annotation classes that are not needed in production) from trino bundle.Brief change log
org.apache.hbase:hbase-serverandorg.apache.commons:commons-lang3in the shadingincluderule and removesorg.apache.hbase:hbase-protocol(not used) in presto bundle. Thecommons-lang3is also shaded.org.apache.hbase:hbase-annotationsfrom trino bundleVerify this pull request
After switching
DEFAULT_METADATA_ENABLE_FOR_READERSto true to enable metadata table reading during queries, the CI passes after this fix (it is broken before this fix).Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.