[HUDI-3921] Improve rewriteRecordWithNewSchema and refactor code #5393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Contributor
Author
|
@nsivabalan @alexeykudinkin could you pls help me review this pr, thanks |
yihua
added
area:schema
| result = parentNames.stream().collect(Collectors.joining(".")); | ||
| } | ||
| return result; | ||
| return StreamSupport |
Contributor
There was a problem hiding this comment.
No need for Stream you can just do String.join
xushiyan
changed the title
Member
|
@xiarixiaoyao can you please rebase and verify this patch via some testing? sorry about the delay. let's try to land this soon. |
danny0405
reviewed
May 23, 2022
| Map<Object, Object> map = (Map<Object, Object>) oldRecord; | ||
| Map<Object, Object> newMap = new HashMap<>(); | ||
| fieldNames.push("value"); | ||
| fieldNames.push(MAP_TYPE_VALUE_NAME); |
Contributor
There was a problem hiding this comment.
If the variable only used by this method, there is no need to make static variables, the JVM would cache the string constants.
Contributor
|
@jonvex could you check if this PR is still needed? |
Contributor
|
A lot of the changes in this pr are already in master. I think it's probably ok to close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed all comments on #5376 and optimize the implementation of rewriteRecordWithNewSchema