[HUDI-3912] Fix lose data when rollback in flink async compact

[wxplovecc]

Tips

• Thank you very much for contributing to Apache Hudi.
• Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.

What is the purpose of the pull request

Currently when rollback a compact action it just revert the request instant to inflight

But in CompactionCommitSink it keep the preview compact event when rollback

It will cause commit too fast before all next real compact events come and use wrong fileId

Brief change log

(for example:)

• Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end.
• Added HoodieClientWriteTest to verify the change.
• Manually verified the change by running a job locally.

Committer checklist

• Has a corresponding JIRA in PR title & commit

• Commit message is descriptive of the change

• CI is green

• Necessary doc changes done or have another open PR

• For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

[wxplovecc]

cc @danny0405

[danny0405]

Can we ensure the buffer was cleared like this:

try {
  // handle failure case
  CompactionUtil.rollbackCompaction(table, instant);
} finally {
  // remove commitBuffer to avoid obsolete metadata commit
  reset(instant);
  return;
}

[danny0405]

Thanks for the contribution @wxplovecc , i have left some minor comments.

[wxplovecc]

Thanks for the contribution @wxplovecc , i have left some minor comments.

done

[danny0405]

+1

[hudi-bot]

CI report:

• d9c0a04 UNKNOWN
• 611fd11 UNKNOWN
• b9bfb0a UNKNOWN
• a312444 Azure: SUCCESS

Bot commands

@hudi-bot supports the following commands:

• @hudi-bot run azure re-run the last Azure build