Skip to content

[HUDI-3621] Fixing NullPointerException in DeltaStreamer #5039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nsivabalan merged 1 commit into from
Mar 14, 2022
Merged

[HUDI-3621] Fixing NullPointerException in DeltaStreamer #5039

nsivabalan merged 1 commit into from
Mar 14, 2022

Conversation

@nsivabalan
Copy link
Contributor

@nsivabalan nsivabalan commented Mar 14, 2022

What is the purpose of the pull request

  • In continuous mode when async clustering is enabled, and if there is no new data to consume for the first time, deltastreamer throws NPE while trying to invoke clustering. bcoz, the writeClient itself is not initialized.

Brief change log

  • Fixed fetching of clustering instant in deltastreamer to return Option.empty if writeclient is not initialized.

Verify this pull request

  • Tested manually with local deltastreamer.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@nsivabalan nsivabalan added status:triaged Issue has been reviewed and categorized priority:critical Production degraded; pipelines stalled labels Mar 14, 2022
yihua
yihua approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hudi-bot
Copy link
Collaborator

hudi-bot commented Mar 14, 2022

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan nsivabalan merged commit 22c3ce7 into apache:master Mar 14, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
@nsivabalan
[HUDI-3621] Fixing NullPointerException in DeltaStreamer (apache#5039)
63eb802
stayrascal pushed a commit to stayrascal/hudi that referenced this pull request Apr 12, 2022
@nsivabalan @stayrascal
[HUDI-3621] Fixing NullPointerException in DeltaStreamer (apache#5039)
07d6929
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yihua yihua yihua approved these changes

Assignees

No one assigned

Labels

priority:critical Production degraded; pipelines stalled status:triaged Issue has been reviewed and categorized

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nsivabalan @hudi-bot @yihua