Skip to content

Conversation

@ljl1988com
Copy link

@ljl1988com ljl1988com commented Mar 14, 2022

https://issues.apache.org/jira/browse/HUDI-3619

Tips

What is the purpose of the pull request

Fix HoodieOperation fromValue using wrong constant value.

Brief change log

Fix HoodieOperation fromValue using wrong constant value.

Verify this pull request

Fix HoodieOperation fromValue using wrong constant value.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

Copy link
Contributor

@wangxianghu wangxianghu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@wangxianghu
Copy link
Contributor

@hudi-bot run azure

@XuQianJin-Stars
Copy link
Contributor

Why skip the number 3?

@ljl1988com
Copy link
Author

Why skip the number 3?

Good question. I also have this question. @XuQianJin-Stars

@wangxianghu
Copy link
Contributor

Why skip the number 3?

Good question. I also have this question. @XuQianJin-Stars

@ljl1988com @XuQianJin-Stars 0, 2^0, 2^1, 2^2 maybe
maybe we should also hear from @swuferhong

@wangxianghu
Copy link
Contributor

hi @ljl1988com please check whether the reasion of ci failure is related to this change

@ljl1988com
Copy link
Author

@wangxianghu I run unit test locally. I find HoodieOperation is like RowKind in flink. I will change the value 4 into 3.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@wangxianghu wangxianghu merged commit 9bdda2a into apache:master Mar 15, 2022
vingov pushed a commit to vingov/hudi that referenced this pull request Apr 3, 2022
stayrascal pushed a commit to stayrascal/hudi that referenced this pull request Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants