Skip to content

Conversation

@vinothchandar
Copy link
Member

@vinothchandar vinothchandar commented Jun 16, 2021

Tips

What is the purpose of the pull request

  • Local tested against standalone Pulsar cluster
  • Tested against a plain avro topic
  • Tested to be able to parse debezium topic with avro convertor

Pending

  • Add tests (unit, functional)
  • Scale test
  • Implement/Test against debezium transformers,payload once the Kafka PR is up.
  • Fix packaging/shading issues

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

 - Local tested against standalone Pulsar cluster
 - Tested against a plain avro topic
 - Tested to be able to parse debezium topic with avro convertor
@vinothchandar vinothchandar added the status:in-progress Work in progress label Jun 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #3096 (733f750) into master (769dd2d) will decrease coverage by 42.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #3096       +/-   ##
============================================
- Coverage     50.04%   8.00%   -42.04%     
+ Complexity     3685      62     -3623     
============================================
  Files           526      75      -451     
  Lines         25466    3036    -22430     
  Branches       2886     378     -2508     
============================================
- Hits          12744     243    -12501     
+ Misses        11454    2772     -8682     
+ Partials       1268      21     -1247     
Flag Coverage Δ
hudicli ?
hudiclient ?
hudicommon ?
hudiflink ?
hudihadoopmr ?
hudisparkdatasource ?
hudisync 6.79% <ø> (-44.66%) ⬇️
huditimelineservice ?
hudiutilities 8.45% <0.00%> (-0.65%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...udi/utilities/sources/pulsar/AvroPulsarSource.java 0.00% <0.00%> (ø)
...utilities/sources/pulsar/PulsarSchemaProvider.java 0.00% <0.00%> (ø)
...che/hudi/utilities/sources/pulsar/PulsarUtils.java 0.00% <0.00%> (ø)
...ilities/sources/pulsar/SerializableSchemaInfo.java 0.00% <0.00%> (ø)
...tilities/sources/pulsar/UnshadedGenericRecord.java 0.00% <0.00%> (ø)
.../org/apache/hudi/hive/NonPartitionedExtractor.java 0.00% <0.00%> (-100.00%) ⬇️
...he/hudi/hive/HiveStylePartitionValueExtractor.java 0.00% <0.00%> (-100.00%) ⬇️
...main/java/org/apache/hudi/hive/HiveSyncConfig.java 0.00% <0.00%> (-97.83%) ⬇️
.../apache/hudi/hive/MultiPartKeysValueExtractor.java 0.00% <0.00%> (-90.91%) ⬇️
...in/java/org/apache/hudi/hive/SchemaDifference.java 0.00% <0.00%> (-84.85%) ⬇️
... and 470 more

@vinothchandar
Copy link
Member Author

As of now, this gives

com.esotericsoftware.kryo.KryoException: java.lang.NullPointerException
Serialization trace:
props (org.apache.pulsar.shade.org.apache.avro.Schema$RecordSchema)
types (org.apache.pulsar.shade.org.apache.avro.Schema$UnionSchema)
schema (org.apache.pulsar.shade.org.apache.avro.Schema$Field)
fieldMap (org.apache.pulsar.shade.org.apache.avro.Schema$RecordSchema)
schema (org.apache.pulsar.shade.org.apache.avro.generic.GenericData$Record)
shadedRecord (org.apache.hudi.utilities.sources.pulsar.UnshadedGenericRecord)
	at com.esotericsoftware.kryo.serializers.ObjectField.read(ObjectField.java:144)
	at com.esotericsoftware.kryo.serializers.FieldSerializer.read(FieldSerializer.java:543)
	at com.esotericsoftware.kryo.Kryo.readClassAndObject(Kryo.java:813)
	at com.esotericsoftware.kryo.serializers.CollectionSerializer.read(CollectionSerializer.java:134)
	at com.esotericsoftware.kryo.serializers.CollectionSerializer.read(CollectionSerializer.java:40)

@ericshao
Copy link

@vinothchandar still working on this PR or not?

@hudi-bot
Copy link
Collaborator

hudi-bot commented Nov 5, 2021

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@xushiyan xushiyan added the priority:high Significant impact; potential bugs label Feb 16, 2022
@xushiyan xushiyan assigned xushiyan and ericshao and unassigned ericshao Feb 16, 2022
@xushiyan
Copy link
Member

Done in #6386

@xushiyan xushiyan closed this Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:high Significant impact; potential bugs status:in-progress Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants