Skip to content

Conversation

@slachiewicz
Copy link
Member

Tags for the Reproducible builds

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Tags for the Reproducible builds
@ayushtkn
Copy link
Member

ayushtkn commented Aug 4, 2022

Got it sorted here: #3498
Not moving above 3.7.1 to keep it sync with Hadoop

@slachiewicz
Copy link
Member Author

ok - that was previously my work here #3309

@slachiewicz slachiewicz closed this Aug 4, 2022
@slachiewicz
Copy link
Member Author

reason to use [3.21.1 and not previous is only becouse previous version dont have feature to use protoc on macos m1.

@ayushtkn
Copy link
Member

ayushtkn commented Aug 4, 2022

3.19.2 should also allow I feel:
https://repo1.maven.org/maven2/com/google/protobuf/protoc/3.19.2/

I wanted to stay with Hadoop for now. OSX won't be used for actual deployments though, but yes for dev env for sure.(I am myself on OSX)

These google dependencies are very good with breaking backward compat, As of now I think I just had 2 HBase failures, which I got fixed, Hopefully won't have any other. But I can check with folks like what issues can it have if we move above hadoop, earlier both hadoop & hive were on 2.5.0

@slachiewicz
Copy link
Member Author

no, anything bellow 3.21.0-rc-2 was wrong.. I've been testing builds on Hive ;-)

protocolbuffers/protobuf#9973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants