[Improve] add connection check when get connection #2333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuluo-yx <[email protected]>
|
hi, the connection cache is the underlying code. If it throws an exception, more upper-level code logic should be considered. |
yuluo-yx
commented
Jul 23, 2024
| this.check(); | ||
| } | ||
| catch (SQLException e) { | ||
| throw new RuntimeException(e.getMessage()); |
There was a problem hiding this comment.
Returning null here and printing the logs would probably block the @tomsun28
Signed-off-by: yuluo-yx <[email protected]>
…luo-yx/hertzbeat into 0722-yuluo/optimize-collector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.