HBASE-20461 Implement fsync for AsyncFSWAL #947
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.regionserver.wal; | ||
|
|
||
| import java.io.IOException; | ||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.fs.FileSystem; | ||
| import org.apache.hadoop.fs.Path; | ||
| import org.apache.hadoop.hbase.HBaseClassTestRule; | ||
| import org.apache.hadoop.hbase.HConstants; | ||
| import org.apache.hadoop.hbase.regionserver.RegionServerServices; | ||
| import org.apache.hadoop.hbase.testclassification.MediumTests; | ||
| import org.junit.AfterClass; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.ClassRule; | ||
| import org.junit.experimental.categories.Category; | ||
|
|
||
| import org.apache.hbase.thirdparty.io.netty.channel.Channel; | ||
| import org.apache.hbase.thirdparty.io.netty.channel.EventLoopGroup; | ||
| import org.apache.hbase.thirdparty.io.netty.channel.nio.NioEventLoopGroup; | ||
| import org.apache.hbase.thirdparty.io.netty.channel.socket.nio.NioSocketChannel; | ||
|
|
||
| @Category({ RegionServerServices.class, MediumTests.class }) | ||
| public class TestAsyncFSWALDurability extends WALDurabilityTestBase<CustomAsyncFSWAL> { | ||
|
|
||
| @ClassRule | ||
| public static final HBaseClassTestRule CLASS_RULE = | ||
| HBaseClassTestRule.forClass(TestAsyncFSWALDurability.class); | ||
|
|
||
| private static NioEventLoopGroup GROUP; | ||
|
|
||
| @BeforeClass | ||
| public static void setUpBeforeClass() { | ||
| GROUP = new NioEventLoopGroup(); | ||
| } | ||
|
|
||
| @AfterClass | ||
| public static void tearDownAfterClass() { | ||
| GROUP.shutdownGracefully(); | ||
| } | ||
|
|
||
| @Override | ||
| protected CustomAsyncFSWAL getWAL(FileSystem fs, Path root, String logDir, Configuration conf) | ||
| throws IOException { | ||
| CustomAsyncFSWAL wal = | ||
| new CustomAsyncFSWAL(fs, root, logDir, conf, GROUP, NioSocketChannel.class); | ||
| wal.init(); | ||
| return wal; | ||
| } | ||
|
|
||
| @Override | ||
| protected void resetSyncFlag(CustomAsyncFSWAL wal) { | ||
| wal.resetSyncFlag(); | ||
| } | ||
|
|
||
| @Override | ||
| protected Boolean getSyncFlag(CustomAsyncFSWAL wal) { | ||
| return wal.getSyncFlag(); | ||
| } | ||
| } | ||
|
|
||
| class CustomAsyncFSWAL extends AsyncFSWAL { | ||
| private Boolean syncFlag; | ||
|
|
||
| public CustomAsyncFSWAL(FileSystem fs, Path rootDir, String logDir, Configuration conf, | ||
| EventLoopGroup eventLoopGroup, Class<? extends Channel> channelClass) | ||
| throws FailedLogCloseException, IOException { | ||
| super(fs, rootDir, logDir, HConstants.HREGION_OLDLOGDIR_NAME, conf, null, true, null, null, | ||
| eventLoopGroup, channelClass); | ||
| } | ||
|
|
||
| @Override | ||
| public void sync(boolean forceSync) throws IOException { | ||
| syncFlag = forceSync; | ||
| super.sync(forceSync); | ||
| } | ||
|
|
||
| @Override | ||
| public void sync(long txid, boolean forceSync) throws IOException { | ||
| syncFlag = forceSync; | ||
| super.sync(txid, forceSync); | ||
| } | ||
|
|
||
| void resetSyncFlag() { | ||
| this.syncFlag = null; | ||
| } | ||
|
|
||
| Boolean getSyncFlag() { | ||
| return syncFlag; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.regionserver.wal; | ||
|
|
||
| import java.io.IOException; | ||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.fs.FileSystem; | ||
| import org.apache.hadoop.fs.Path; | ||
| import org.apache.hadoop.hbase.HBaseClassTestRule; | ||
| import org.apache.hadoop.hbase.regionserver.RegionServerServices; | ||
| import org.apache.hadoop.hbase.testclassification.MediumTests; | ||
| import org.junit.ClassRule; | ||
| import org.junit.experimental.categories.Category; | ||
|
|
||
| @Category({ RegionServerServices.class, MediumTests.class }) | ||
| public class TestFSHLogDurability extends WALDurabilityTestBase<CustomFSHLog> { | ||
|
|
||
| @ClassRule | ||
| public static final HBaseClassTestRule CLASS_RULE = | ||
| HBaseClassTestRule.forClass(TestFSHLogDurability.class); | ||
|
|
||
| @Override | ||
| protected CustomFSHLog getWAL(FileSystem fs, Path root, String logDir, Configuration conf) | ||
| throws IOException { | ||
| CustomFSHLog wal = new CustomFSHLog(fs, root, logDir, conf); | ||
| wal.init(); | ||
| return wal; | ||
| } | ||
|
|
||
| @Override | ||
| protected void resetSyncFlag(CustomFSHLog wal) { | ||
| wal.resetSyncFlag(); | ||
| } | ||
|
|
||
| @Override | ||
| protected Boolean getSyncFlag(CustomFSHLog wal) { | ||
| return wal.getSyncFlag(); | ||
| } | ||
| } | ||
|
|
||
| class CustomFSHLog extends FSHLog { | ||
| private Boolean syncFlag; | ||
|
|
||
| public CustomFSHLog(FileSystem fs, Path root, String logDir, Configuration conf) | ||
| throws IOException { | ||
| super(fs, root, logDir, conf); | ||
| } | ||
|
|
||
| @Override | ||
| public void sync(boolean forceSync) throws IOException { | ||
| syncFlag = forceSync; | ||
| super.sync(forceSync); | ||
| } | ||
|
|
||
| @Override | ||
| public void sync(long txid, boolean forceSync) throws IOException { | ||
| syncFlag = forceSync; | ||
| super.sync(txid, forceSync); | ||
| } | ||
|
|
||
| void resetSyncFlag() { | ||
| this.syncFlag = null; | ||
| } | ||
|
|
||
| Boolean getSyncFlag() { | ||
| return syncFlag; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always get these confused? You can't just call it sync? Whats diff between hsync, sync, and fsync again? I forgot?