Skip to content

HBASE-23224 Delete the TODO tag #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q977734161 wants to merge 2 commits into from
Closed

HBASE-23224 Delete the TODO tag #768

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
744441f
HBASE-23224 Delete the TODO tag
q977734161 Oct 28, 2019
07af6b2
Merge pull request #1 from apache/master
q977734161 Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions ...ocedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,8 @@ public interface LeaseRecovery {

// Variables used for UI display
private CircularFifoQueue<SyncMetrics> syncMetricsQueue;
private int syncMetricsQueueSize = 0;
private int syncMetricsQueueIndex = 0;

public static class SyncMetrics {
private long timestamp;
Expand Down Expand Up @@ -303,8 +305,8 @@ public void start(int numSlots) throws IOException {
useHsync = conf.getBoolean(USE_HSYNC_CONF_KEY, DEFAULT_USE_HSYNC);

// WebUI
syncMetricsQueue = new CircularFifoQueue<>(
conf.getInt(STORE_WAL_SYNC_STATS_COUNT, DEFAULT_SYNC_STATS_COUNT));
syncMetricsQueueSize = conf.getInt(STORE_WAL_SYNC_STATS_COUNT, DEFAULT_SYNC_STATS_COUNT);
syncMetricsQueue = new CircularFifoQueue<>(syncMetricsQueueSize);

// Init sync thread
syncThread = new Thread("WALProcedureStoreSyncThread") {
Expand Down Expand Up @@ -848,14 +850,24 @@ private void syncLoop() throws Throwable {
StringUtils.humanSize(syncedPerSec)));
}

// update webui circular buffers (TODO: get rid of allocations)
final SyncMetrics syncMetrics = new SyncMetrics();
// update webui circular buffers
SyncMetrics syncMetrics = null;
if (syncMetricsQueue.isAtFullCapacity()) {
if (syncMetricsQueueIndex == syncMetricsQueueSize) {
syncMetricsQueueIndex = 0;
}
syncMetrics = syncMetricsQueue.get(syncMetricsQueueIndex);
syncMetricsQueueIndex ++;
Copy link
Contributor

@xcangCRM xcangCRM Nov 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be syncMetricsQueueIndex++; ?

Copy link
Contributor Author

@q977734161 q977734161 Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, syncMetricsQueueIndex ++ in order reuse next SyncMetrics Object in syncMetricsQueue.

} else {
syncMetrics = new SyncMetrics();
syncMetricsQueue.add(syncMetrics);
}

syncMetrics.timestamp = currentTs;
syncMetrics.syncWaitMs = syncWaitMs;
syncMetrics.syncedEntries = slotIndex;
syncMetrics.totalSyncedBytes = totalSyncedToStore;
syncMetrics.syncedPerSec = syncedPerSec;
syncMetricsQueue.add(syncMetrics);

// sync
inSync.set(true);
Expand Down