HBASE-29797 Should not create wal directory when creating WAL instance #7585

Apache9 · 2025-12-31T16:17:25Z

No description provided.

Apache9 · 2025-12-31T16:18:51Z

The fix is simple, but the most challenging thing is how to make existing tests pass, without modifying too much code.

Let's see the pre commit result, I believe there will still be some failures...

Umeshkumar9414

LGTM

Umeshkumar9414

I thought tests are passing. But looks like there are many yet to fix.

Apache9 · 2026-01-03T09:50:31Z

I thought tests are passing. But looks like there are many yet to fix.

Yes, we still need some time for polishing the test code.

Apache-HBase · 2026-01-03T16:58:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 22s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 29s		master passed
+1 💚	compile	8m 51s		master passed
+1 💚	checkstyle	2m 23s		master passed
+1 💚	spotbugs	9m 33s		master passed
+1 💚	spotless	0m 53s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	3m 10s		the patch passed
+1 💚	compile	8m 44s		the patch passed
+1 💚	javac	8m 44s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 18s		the patch passed
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	9m 44s		the patch passed
+1 💚	hadoopcheck	12m 24s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 47s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 23s		The patch does not generate ASF License warnings.
		72m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7585
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname	Linux ef52e49a7162 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d77da02`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	193 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/5/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-03T21:15:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 27s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 57s		master passed
+1 💚	compile	2m 7s		master passed
+1 💚	javadoc	2m 23s		master passed
+1 💚	shadedjars	6m 2s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s		the patch passed
+1 💚	compile	2m 9s		the patch passed
+1 💚	javac	2m 9s		the patch passed
+1 💚	javadoc	2m 24s		the patch passed
+1 💚	shadedjars	5m 57s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	293m 22s	/patch-unit-root.txt	root in the patch failed.
		329m 47s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7585
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 2eae95d01d8b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d77da02`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/5/testReport/
Max. process+thread count	6347 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/5/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-04T05:39:28Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 31s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 34s		Maven dependency ordering for branch
+1 💚	mvninstall	3m 13s		master passed
+1 💚	compile	2m 8s		master passed
+1 💚	javadoc	2m 22s		master passed
+1 💚	shadedjars	6m 3s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 54s		the patch passed
+1 💚	compile	2m 6s		the patch passed
+1 💚	javac	2m 6s		the patch passed
+1 💚	javadoc	2m 27s		the patch passed
+1 💚	shadedjars	5m 56s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	3m 16s	/patch-unit-root.txt	root in the patch failed.
		33m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7585
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux d95f5c86046c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d77da02`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/6/testReport/
Max. process+thread count	311 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/6/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-04T05:59:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 25s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 40s		master passed
+1 💚	compile	6m 26s		master passed
+1 💚	checkstyle	1m 44s		master passed
+1 💚	spotbugs	6m 57s		master passed
+1 💚	spotless	0m 40s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 20s		the patch passed
+1 💚	compile	6m 28s		the patch passed
+1 💚	javac	6m 28s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 44s		the patch passed
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	7m 5s		the patch passed
+1 💚	hadoopcheck	8m 34s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 33s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 15s		The patch does not generate ASF License warnings.
		53m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/6/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7585
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname	Linux 1178231ba9cb 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d77da02`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	194 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/6/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-04T06:51:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 9s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	hbaseanti	0m 0s		Patch does not have any anti-patterns.
			_ master Compile Tests _
+0 🆗	mvndep	0m 14s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 14s		master passed
+1 💚	compile	6m 27s		master passed
+1 💚	checkstyle	1m 43s		master passed
+1 💚	spotbugs	6m 55s		master passed
+1 💚	spotless	0m 33s		branch has no errors when running spotless:check.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 16s		the patch passed
+1 💚	compile	6m 26s		the patch passed
+1 💚	javac	6m 26s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 45s		the patch passed
+1 💚	xmllint	0m 0s		No new issues.
+1 💚	spotbugs	7m 7s		the patch passed
+1 💚	hadoopcheck	8m 21s		Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚	spotless	0m 33s		patch has no errors when running spotless:check.
			_ Other Tests _
+1 💚	asflicense	0m 15s		The patch does not generate ASF License warnings.
		50m 48s

Subsystem	Report/Notes
Docker	ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/7/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#7585
Optional Tests	dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile spotbugs checkstyle hbaseanti
uname	Linux 2c9285cd3942 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d77da02`
Default Java	Eclipse Adoptium-17.0.11+9
Max. process+thread count	195 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/7/console
versions	git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2026-01-04T11:26:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 28s		Docker mode activated.
-0 ⚠️	yetus	0m 3s		Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
			_ Prechecks _
			_ master Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for branch
+1 💚	mvninstall	2m 58s		master passed
+1 💚	compile	2m 7s		master passed
+1 💚	javadoc	2m 22s		master passed
+1 💚	shadedjars	5m 58s		branch has no errors when building our shaded downstream artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 53s		the patch passed
+1 💚	compile	2m 9s		the patch passed
+1 💚	javac	2m 9s		the patch passed
+1 💚	javadoc	2m 23s		the patch passed
+1 💚	shadedjars	5m 57s		patch has no errors when building our shaded downstream artifacts.
			_ Other Tests _
-1 ❌	unit	289m 54s	/patch-unit-root.txt	root in the patch failed.
		325m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR	#7585
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e94acb10c6f3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `d77da02`
Default Java	Eclipse Adoptium-17.0.11+9
Test Results	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/7/testReport/
Max. process+thread count	6321 (vs. ulimit of 30000)
modules	C: hbase-server . U: .
Console output	https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7585/7/console
versions	git=2.34.1 maven=3.9.8
Powered by	Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2026-01-04T15:58:07Z

Test locally, the TestSecureExportSnapshot passed for me, it should not related to the modification here, and I found that in HBASE-24493 we disabled TestExportSnapshot, but we do not disable the tests which extends it...

Will file follow on issue to track this failure.

Apache9 · 2026-01-05T14:27:59Z

Filed HBASE-29802 for tracking TestSecureExportSnapshot.

#7585) Signed-off-by: Charles Connell <[email protected]> (cherry picked from commit add6f22)

apache#7585) Signed-off-by: Charles Connell <[email protected]> (cherry picked from commit add6f22)

#7585)(#7589) Signed-off-by: Charles Connell <[email protected]> (cherry picked from commit add6f22)

Apache9 self-assigned this Dec 31, 2025

This comment has been minimized.

Sign in to view

Umeshkumar9414 approved these changes Jan 2, 2026

View reviewed changes

Umeshkumar9414 suggested changes Jan 2, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

HBASE-29797 Should not create wal directory when creating WAL instance

d77da02

Apache9 force-pushed the HBASE-29797 branch from e0c4c1e to d77da02 Compare January 3, 2026 15:38

charlesconnell approved these changes Jan 5, 2026

View reviewed changes

Apache9 merged commit add6f22 into apache:master Jan 5, 2026
1 check failed

Apache9 added a commit that referenced this pull request Jan 5, 2026

HBASE-29797 Should not create wal directory when creating WAL instance (

e22a193

#7585) Signed-off-by: Charles Connell <[email protected]> (cherry picked from commit add6f22)

Apache9 added a commit to Apache9/hbase that referenced this pull request Jan 5, 2026

HBASE-29797 Should not create wal directory when creating WAL instance (

51a056d

apache#7585) Signed-off-by: Charles Connell <[email protected]> (cherry picked from commit add6f22)

Apache9 mentioned this pull request Jan 5, 2026

HBASE-29797 Should not create wal directory when creating WAL instanc… #7589

Merged

Apache9 added a commit that referenced this pull request Jan 8, 2026

HBASE-29797 Should not create wal directory when creating WAL instance (

5a5f273

#7585)(#7589) Signed-off-by: Charles Connell <[email protected]> (cherry picked from commit add6f22)

Apache9 added a commit that referenced this pull request Jan 8, 2026

HBASE-29797 Should not create wal directory when creating WAL instance (

0814737

#7585)(#7589) Signed-off-by: Charles Connell <[email protected]> (cherry picked from commit add6f22)

Apache9 added a commit that referenced this pull request Jan 8, 2026

HBASE-29797 Should not create wal directory when creating WAL instance (

8ccccb5

#7585)(#7589) Signed-off-by: Charles Connell <[email protected]> (cherry picked from commit add6f22)

HBASE-29797 Should not create wal directory when creating WAL instance #7585

HBASE-29797 Should not create wal directory when creating WAL instance #7585

Uh oh!

Conversation

Apache9 commented Dec 31, 2025

Uh oh!

Apache9 commented Dec 31, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Umeshkumar9414 left a comment

Choose a reason for hiding this comment

Uh oh!

Umeshkumar9414 left a comment

Choose a reason for hiding this comment

Uh oh!

Apache9 commented Jan 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Apache-HBase commented Jan 3, 2026

Uh oh!

Apache-HBase commented Jan 3, 2026

Uh oh!

Apache-HBase commented Jan 4, 2026

Uh oh!

Apache-HBase commented Jan 4, 2026

Uh oh!

Apache-HBase commented Jan 4, 2026

Uh oh!

Apache-HBase commented Jan 4, 2026

Uh oh!

Apache9 commented Jan 4, 2026

Uh oh!

Apache9 commented Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants