HBASE-29789: Backport 'HBASE-29761: The HBase UI's Debug Dump is not redacting sensitive information' to branch-2 #7568
+339
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redacting sensitive information' to branch-2 Change-Id: Ib3fa2674e9362b038e37df1a32ad35094811a00d
kgeisz
force-pushed
the
HBASE-29789-backport-HBASE-29761-debug-dump-redact-fix-to-branch-2
branch
from
796c610 to
23b2817
Compare
kgeisz
changed the title
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
taklwu
requested changes
Dec 22, 2025
|
|
||
| String page = getRegionServerStatusPageContent(hostname, infoPort); | ||
| URL url = new URL("http://" + hostname + ":" + infoPort + "/regionserver.jsp"); | ||
| String page = TestServerHttpUtils.getPageContent(url, "text/html;charset=utf-8"); |
Contributor
There was a problem hiding this comment.
the test failed
[ERROR] org.apache.hadoop.hbase.regionserver.http.TestRSStatusPage.testStatusPage -- Time elapsed: 1.225 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<text/html[;charset=utf-8]> but was:<text/html[]>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at org.apache.hadoop.hbase.util.TestServerHttpUtils.getPageContent(TestServerHttpUtils.java:44)
at org.apache.hadoop.hbase.regionserver.http.TestRSStatusPage.testStatusPage(TestRSStatusPage.java:125)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.lang.Thread.run(Thread.java:829)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HBASE-29789
This pull request back-ports HBASE-29761: The HBase UI's Debug Dump is not redacting sensitive information into branch-2. HBASE-29761 fixes an issue where sensitive information, such as passwords, were not being redacted when looking at a server's Debug Dump in the HBase UI. Some small modifications needed to be made in the Java code in order to get this commit to build. The changes included:
MasterDumpServlet.java and RSDumpServlet.java
StandardCharsets.UTF_8.toString()instead ofStandardCharsets.UTF_8MasterDumpServlet.java
if (isShowQueueDump(conf))toif (isShowQueueDump(master.getConfiguration()))since theconfvariable no longer exists in the code (the master branch does not have thisifblock at all).TestDebugDumpRedaction.java
HBaseTestingUtilityinstead ofHBaseTestingUtilREDACTED_PROPSusingArrays.asList()instead ofList.of()and using.collect(Collectors.toList())instead of.toList().TestServerHttpUtils.java
static final String PLAIN_TEXT = "text/plain"instead ofstatic final String PLAIN_TEXT_UTF8 = "text/plain;charset=utf-8".