-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29783 Fix flaky TestVerifyBucketCacheFile.testRetrieveFromFile test #7561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test Change-Id: I032121dde597c47adb343502f33b73fb31f0f568
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
petersomogyi
approved these changes
Dec 18, 2025
Contributor
petersomogyi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
liuxiaocs7
approved these changes
Dec 19, 2025
wchevreuil
added a commit
that referenced
this pull request
Dec 19, 2025
…test (#7561) Signed-off-by: Peter Somogyi <[email protected]>
wchevreuil
added a commit
to wchevreuil/hbase
that referenced
this pull request
Dec 19, 2025
…test (apache#7561) Signed-off-by: Peter Somogyi <[email protected]> Change-Id: I57fdef54e953a94a24020c99c3ebbc2741fdf519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestVerifyBucketCacheFile is on the flaky list for master branch, with testRetrieveFromFile failing the check scenario where the index (backingMap) is recoverable, but not the cache file itself. I believe this is because on line #141 we are waiting until bucket cache is initialised (cacheState == ENABLED), however, in cases where the backingMap and the cache file are inconsistent, we perform a background validation of the backingMap, even after the cache is in ENABLED state.