Skip to content

HBASE-29767 Fix IOTimePerHit NaN issue in BucketCacheStats #7535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
guluo2016 merged 3 commits into from
Dec 12, 2025
Merged

HBASE-29767 Fix IOTimePerHit NaN issue in BucketCacheStats #7535

guluo2016 merged 3 commits into from
Dec 12, 2025
+20 −1

Conversation

@guluo2016
Copy link
Member

@guluo2016 guluo2016 commented Dec 10, 2025

Details see: HBASE-29767

@Apache-HBase

This comment has been minimized.

Sign in to view
liuxiaocs7
liuxiaocs7 approved these changes Dec 10, 2025
View reviewed changes
Copy link
Contributor

@liuxiaocs7 liuxiaocs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

PDavid
PDavid reviewed Dec 10, 2025
View reviewed changes
Copy link
Contributor

@PDavid PDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. Is it possible to add a unit test for this?

@guluo2016
Copy link
Member Author

guluo2016 commented Dec 10, 2025

Thanks for fixing. Is it possible to add a unit test for this?

Done, thanks for the reviewing!

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase
Copy link

Apache-HBase commented Dec 10, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 31s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 35s master passed
+1 💚 compile 3m 37s master passed
+1 💚 checkstyle 1m 0s master passed
+1 💚 spotbugs 1m 39s master passed
+1 💚 spotless 0m 51s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 8s the patch passed
+1 💚 compile 3m 22s the patch passed
+1 💚 javac 3m 22s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 58s the patch passed
+1 💚 spotbugs 1m 44s the patch passed
+1 💚 hadoopcheck 12m 5s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 45s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
41m 18s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7535/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7535
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 04fc34306d2c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d3d056e
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7535/2/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Dec 10, 2025

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 52s master passed
+1 💚 compile 1m 10s master passed
+1 💚 javadoc 0m 34s master passed
+1 💚 shadedjars 6m 46s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 39s the patch passed
+1 💚 compile 1m 11s the patch passed
+1 💚 javac 1m 11s the patch passed
+1 💚 javadoc 0m 30s the patch passed
+1 💚 shadedjars 6m 8s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 211m 47s /patch-unit-hbase-server.txt hbase-server in the patch failed.
240m 32s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7535/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7535
Optional Tests javac javadoc unit compile shadedjars
uname Linux 4b6848c0b4c9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / d3d056e
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7535/2/testReport/
Max. process+thread count 3995 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7535/2/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Dec 11, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 1m 34s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 2m 45s master passed
+1 💚 compile 2m 32s master passed
+1 💚 checkstyle 0m 46s master passed
+1 💚 spotbugs 1m 13s master passed
+1 💚 spotless 0m 39s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 2m 13s the patch passed
+1 💚 compile 2m 30s the patch passed
+1 💚 javac 2m 30s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 44s the patch passed
+1 💚 spotbugs 1m 16s the patch passed
+1 💚 hadoopcheck 8m 26s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 33s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 9s The patch does not generate ASF License warnings.
30m 36s
Subsystem Report/Notes
Docker ClientAPI=1.48 ServerAPI=1.48 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7535/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7535
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless
uname Linux 96ea05bc7d13 6.8.0-1024-aws #26~22.04.1-Ubuntu SMP Wed Feb 19 06:54:57 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8cfb31a
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 87 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7535/3/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Dec 11, 2025

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 40s master passed
+1 💚 compile 1m 0s master passed
+1 💚 javadoc 0m 29s master passed
+1 💚 shadedjars 6m 11s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 6s the patch passed
+1 💚 compile 1m 0s the patch passed
+1 💚 javac 1m 0s the patch passed
+1 💚 javadoc 0m 27s the patch passed
+1 💚 shadedjars 6m 11s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 227m 19s hbase-server in the patch passed.
254m 52s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7535/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7535
Optional Tests javac javadoc unit compile shadedjars
uname Linux 022c9654aaf9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 8cfb31a
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7535/3/testReport/
Max. process+thread count 3913 (vs. ulimit of 30000)
modules C: hbase-server U: hbase-server
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7535/3/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

PDavid
PDavid approved these changes Dec 12, 2025
View reviewed changes
Copy link
Contributor

@PDavid PDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and for adding the test. 👍

@guluo2016
Copy link
Member Author

guluo2016 commented Dec 12, 2025

Thanks for reviewing @liuxiaocs7 @Apache9 @PDavid

@guluo2016 guluo2016 merged commit 168bd52 into apache:master Dec 12, 2025
1 check passed
guluo2016 added a commit that referenced this pull request Dec 12, 2025
@guluo2016
HBASE-29767 Fix IOTimePerHit NaN issue in BucketCacheStats (#7535)
7acb652 
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Dávid Paksy <[email protected]>
Reviewed-by: Liu Xiao <[email protected]>
guluo2016 added a commit that referenced this pull request Dec 12, 2025
@guluo2016
HBASE-29767 Fix IOTimePerHit NaN issue in BucketCacheStats (#7535)
49eb80c 
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Dávid Paksy <[email protected]>
Reviewed-by: Liu Xiao <[email protected]>
guluo2016 added a commit that referenced this pull request Dec 12, 2025
@guluo2016
HBASE-29767 Fix IOTimePerHit NaN issue in BucketCacheStats (#7535)
7bb12a2 
Signed-off-by: Duo Zhang <[email protected]>
Signed-off-by: Dávid Paksy <[email protected]>
Reviewed-by: Liu Xiao <[email protected]>
@guluo2016 guluo2016 mentioned this pull request Dec 12, 2025
Merged
@guluo2016 guluo2016 deleted the hbase_HBASE-29767 branch December 15, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PDavid PDavid PDavid approved these changes

@Apache9 Apache9 Apache9 approved these changes

+1 more reviewer

@liuxiaocs7 liuxiaocs7 liuxiaocs7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@guluo2016 @Apache-HBase @PDavid @Apache9 @liuxiaocs7