-
Notifications
You must be signed in to change notification settings - Fork 3.4k
HBASE-29596 Migrate Canary Status Jamon page back to JSP #7531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-29596 Migrate Canary Status Jamon page back to JSP #7531
Conversation
This is the last step of the Jamon to JSP migration: the Canary Status page. Migrated the Jamon code to JSP as close as possible. Extracted some duplicated server link code to new java class: CanaryStatusUtil and added unit tests. Changed the Canary Server Status page back to `/canary.jsp`. Made sure that `/canary-status` redirects to `/canary.jsp`. Introduced a `src/main/resources/hbase-webapps/common` directory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit. Made sure to compile Canary JSP files the same way as we do for Master and Region server JSP pages. Removed the Jamon Maven dependencies and references to Jamon code. Signed-off-by: Istvan Toth <[email protected]> Signed-off-by: Nihal Jain <[email protected]> (cherry picked from commit 4ba9b46)
|
This is a backport of #7390 to The cherry-pick applied almost cleanly, the only difference is that the master patch had a 1 line change in TestingTested the patch the same way as described here: #7390 (comment) |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
|
This is the last step of the Jamon to JSP migration: the Canary Status page.
Migrated the Jamon code to JSP as close as possible. Extracted some duplicated server link code to new java class: CanaryStatusUtil and added unit tests.
Changed the Canary Server Status page back to
/canary.jsp. Made sure that/canary-statusredirects to/canary.jsp.Introduced a
src/main/resources/hbase-webapps/commondirectory where we can place common JSP files which are used by both Master and RegionServer JSP pages. This required to adjust the JSP compiler Maven Antrun plugin a bit.Made sure to compile Canary JSP files the same way as we do for Master and Region server JSP pages.
Removed the Jamon Maven dependencies and references to Jamon code.
(cherry picked from commit 4ba9b46)